Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set invalid instance UID error throw #218

Conversation

Sairam-Arpavur-Natarajan
Copy link
Contributor

Fixing error throw logger when setting invalid instance UID provided by the server.

@Sairam-Arpavur-Natarajan Sairam-Arpavur-Natarajan requested a review from a team December 20, 2023 17:41
Copy link

linux-foundation-easycla bot commented Dec 20, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sairam866 / name: Sairam Arpavur Natarajan (3a7838d, 2d8c193)

@tigrannajaryan
Copy link
Member

Thank you for the fix @sairam866
Please sign the CLA so that we can accept the PR.

@Sairam-Arpavur-Natarajan
Copy link
Contributor Author

@tigrannajaryan Updated my commit with my company email. CLA should be fine now.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (efddaa2) 76.11% compared to head (2d8c193) 72.50%.
Report is 32 commits behind head on main.

Files Patch % Lines
internal/certs.go 0.00% 118 Missing ⚠️
client/internal/httpsender.go 88.00% 2 Missing and 1 partial ⚠️
client/internal/mockserver.go 85.71% 2 Missing and 1 partial ⚠️
server/httpconnection.go 0.00% 2 Missing ⚠️
client/internal/clientcommon.go 90.90% 1 Missing ⚠️
client/internal/packagessyncer.go 0.00% 1 Missing ⚠️
client/internal/receivedprocessor.go 90.90% 1 Missing ⚠️
server/serverimpl.go 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   76.11%   72.50%   -3.62%     
==========================================
  Files          24       25       +1     
  Lines        1834     2022     +188     
==========================================
+ Hits         1396     1466      +70     
- Misses        326      446     +120     
+ Partials      112      110       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigrannajaryan tigrannajaryan merged commit cded8e3 into open-telemetry:main Dec 20, 2023
3 of 5 checks passed
@tigrannajaryan
Copy link
Member

Thanks @sairam866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants