Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format code #94

Merged
merged 2 commits into from
Jul 11, 2024
Merged

format code #94

merged 2 commits into from
Jul 11, 2024

Conversation

ishiko732
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4fb4064) to head (9632929).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          352       352           
  Branches        44        44           
=========================================
  Hits           352       352

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishiko732 ishiko732 marked this pull request as ready for review July 10, 2024 15:32
@ishiko732 ishiko732 requested a review from L-M-Sherlock July 10, 2024 15:34
L-M-Sherlock
L-M-Sherlock approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-M-Sherlock
Copy link
Member

L-M-Sherlock commented Jul 11, 2024 •
edited
Loading

By the way, why does the formatter replace " with '?

@ishiko732
Copy link
Collaborator Author

By the way, why does the formatter replace " with '?

Most JavaScript/TypeScript projects use single quotes. Additionally, using single quotes doesn't require pressing the ⇧ Shift key. Since ts-fsrs doesn't involve embedding HTML code, there's no need to use double quotes.

@L-M-Sherlock L-M-Sherlock merged commit 8d61183 into main Jul 11, 2024
5 checks passed
@ishiko732 ishiko732 deleted the Style/format branch July 14, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-M-Sherlock L-M-Sherlock L-M-Sherlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishiko732 @L-M-Sherlock