Github CI/CD: Bump action version from v3 to v4. #362
Conversation
3413f45 to
28ba322
Compare
.github/workflows/build.yml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| ## macos-10.15: Runner seems to be officially disabled, results in canceled | |||
There was a problem hiding this comment.
I'll take it out. :-)
| @@ -11,7 +11,7 @@ jobs: | |||
| matrix: | |||
| os: [ubuntu-20.04, ubuntu-22.04] | |||
There was a problem hiding this comment.
Line 26 in build.yml now says ubuntu-latest, does that apply here too?
There was a problem hiding this comment.
cmake-builds.yml produces artifacts, so the idea here is to list out the operating systems for which artifacts are produced. There are two Ubuntu images in the GH image runner collection (one of which is "ubuntu-latest"), so I explicitly spelled out the versions.
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [macos-12, macos-11] | ||
| os: [macos-12, macos-13, macos-14] |
There was a problem hiding this comment.
In the other file you have macos-latest, would that make sense here?
Also, what does it mean to list several OS versions? Does it run on all of them, or just on whichever one (if any) is available?
There was a problem hiding this comment.
See previous comment.
There was a problem hiding this comment.
Artifacts, artifacts, artifacts!!!
There was a problem hiding this comment.
BTW: The image name, e.g. "macos-14", appears in the artifact name. So, "-latest" might be awkward.
There was a problem hiding this comment.
I understand the difference now, that makes sense. A comment might help.
PS. "Artefact" is the original spelling, still used in Britain and Australia and also how the corresponding word is spelled in several other languages. :-)
28ba322 to
2561191
Compare
The two matrices could be congruent, but I don't really see a compelling reason to do so. |
- Per Github messages, upgrade checkout@v3 to checkout@v4 due to an upgrade to Node.js. - macos-11 is now a defunct image runner. Homebrew packages either have to compile from source or no longer install correctly. - Update the macos compile matrix. Set CPACK_SUFFIX environment variable to indicate macOS hardware platform: macos-14 is M1, whereas macos-12 and macos-13 are x86_64. - Added notes with respect to the matrix.strategy runner images. The makefile builds use "-latest" because they don't produce artifacts, while (*) the CMake builds enumerate the images for which artifacts (+) are produced and the runner image's name is part of the artifact. (*) "Whilst" for the rest of the Anglosphere. (+) "Artefact" for the rest of the Anglosphere.
2561191 to
d3b003c
Compare
|
Notes added to build.yml and cmake-builds.yml re: runner image names. |
Github upgraded Node.js from version 16 to version 20; Node.js drives the CI/CD pipelines. Github strongly recommends bumping the actions' version number from "@V3" to "@v4" and produces copious warning messages in the CI/CD "Annotations" pane for each submission.