Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option for Arch Linux to .travis/deps.sh #351

Closed
wants to merge 4 commits into from

Conversation

PurpleAce88
Copy link
Contributor

Added an option that uses pacman to install everything, therefore making setup simpler for Arch users.

Added an option that uses pacman to install everything, therefore making setup simpler for Arch users.
@PurpleAce88 PurpleAce88 changed the title Added an option for Arch Linux. Added an option for Arch Linux to .travis/deps.sh Feb 5, 2024
@pkoning2
Copy link
Member

I've never heard of ArchLinux. Is that some obscure packager?
It seems odd for the OS name to be "arch" when there is also "linux". Can it check the packager name if you say "linux" and do the incompatible magic? If not, "arch_linux" or "arch-linux" seems like a better name.

@PurpleAce88
Copy link
Contributor Author

Archlinux is a minimalist Linux distribution, its default package manager is pacman. Yes it may be able to check the package manager you're using, but I thought it best to keep things simpler and just require the user to specify Arch. Yes it may be better to name it arch-linux or arch_linux, although I thought it would be distinct enough, as I only know of one operating system that is named Arch.

@pkoning2
Copy link
Member

The reason I suggested arch-linux is that it makes it clear it's a flavor of Linux, rather than a distinct operating system like MacOS or FreeBSD or VMS.

@PurpleAce88
Copy link
Contributor Author

Good point, I can fix that

@markpizz
Copy link
Contributor

One thing about this PR is the personal name on Github of @PurpleAce88 . It is hard for me to believe that "Ender Wiggin" is actually your name.

Wikipedia says:

Andrew "Ender" Wiggin is a fictional character from Orson Scott Card's 1985 science fiction novel Ender's Game and its sequels, as well as in the first part of the spin-off series, Ender's Shadow. The book series itself is an expansion of Card's 1977 short story "Ender's Game."

Generally, we'd like to see the real name of the folks who submit changes. Another PR hasn't been merged for this very reason....

@PurpleAce88
Copy link
Contributor Author

Oh. I should probably change that. You are correct my name is not Ender Wiggin. I have changed my profile accordingly to display my correct name.

@pkoning2
Copy link
Member

Thanks, so could you close this PR and resubmit it with your real name on the commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants