Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AltairZ80: CPU changes no longer remove device memory maps #345

Closed
wants to merge 1 commit into from

Conversation

deltecent
Copy link
Contributor

Changing the CPU's memory or CPU configuration currently removes memory mapped by a device:

sim> set jadedd ena
sim> show cpu
CPU
        64KB, NOITRAP, 8080, AZ80, STOPONHALT
        NONBANKED, ALTAIRROM, VERBOSE,
       0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF [16k]
00000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
04000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
08000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
0C000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWMMMMWWWWWWWWWWWWMMMMWWWWWWWWWWWR,
0x[02 03 04 05 08 09 0A 10 11 12 13 14 15 16 17 18 19 28 29 2A 2B 32 33 43 A0 A1 A2 A3 A4 A5 A6 A7 FD FE FF]
        MMU, NOSWITCHER, NOPO
sim> set cpu 24k
sim> show cpu
CPU
        24KB, NOITRAP, 8080, AZ80, STOPONHALT
        NONBANKED, ALTAIRROM, VERBOSE,
       0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF [16k]
00000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
04000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU
08000: UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU
0C000: UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUR,
0x[02 03 04 05 08 09 0A 10 11 12 13 14 15 16 17 18 19 28 29 2A 2B 32 33 43 A0 A1 A2 A3 A4 A5 A6 A7 FD FE FF]
        MMU, NOSWITCHER, NOPO
sim>

Changing the CPU type or memory configuration should not change a device's configuration. This PR modifies cpu_clear() to no longer cause device memory maps to be removed from MDEV mmu_table[] when the following CPU commands are executed:

CPU [NO]BANKED
CPU CLEARMEMORY
CPU [CHIP TYPE]
CPU [MEMORY SIZE]
sim> set jadedd ena
sim> show cpu
CPU
        64KB, NOITRAP, 8080, AZ80, STOPONHALT
        NONBANKED, ALTAIRROM, VERBOSE,
       0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF [16k]
00000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
04000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
08000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
0C000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWMMMMWWWWWWWWWWWWMMMMWWWWWWWWWWWR,
0x[02 03 04 05 08 09 0A 10 11 12 13 14 15 16 17 18 19 28 29 2A 2B 32 33 43 A0 A1 A2 A3 A4 A5 A6 A7 FD FE FF]
        MMU, NOSWITCHER, NOPO
sim> set cpu 24k
sim> show cpu
CPU
        24KB, NOITRAP, 8080, AZ80, STOPONHALT
        NONBANKED, ALTAIRROM, VERBOSE,
       0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF [16k]
00000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
04000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU
08000: UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU
0C000: UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUMMMMUUUUUUUUUUUUMMMMUUUUUUUUUUUR,
0x[02 03 04 05 08 09 0A 10 11 12 13 14 15 16 17 18 19 28 29 2A 2B 32 33 43 A0 A1 A2 A3 A4 A5 A6 A7 FD FE FF]
        MMU, NOSWITCHER, NOPO
sim>

When a device maps memory, changing the CPU's memory or CPU
configuration removes memory mapped by a device:

sim> set jadedd ena
sim> show cpu
CPU
        64KB, NOITRAP, 8080, AZ80, STOPONHALT
        NONBANKED, ALTAIRROM, VERBOSE,
       0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF [16k]
00000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
04000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
08000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
0C000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWMMMMWWWWWWWWWWWWMMMMWWWWWWWWWWWR,
0x[02 03 04 05 08 09 0A 10 11 12 13 14 15 16 17 18 19 28 29 2A 2B 32 33 43 A0 A1 A2 A3 A4 A5 A6 A7 FD FE FF]
        MMU, NOSWITCHER, NOPO
sim> set cpu 24k
sim> show cpu
CPU
        24KB, NOITRAP, 8080, AZ80, STOPONHALT
        NONBANKED, ALTAIRROM, VERBOSE,
       0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF [16k]
00000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
04000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU
08000: UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU
0C000: UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUR,
0x[02 03 04 05 08 09 0A 10 11 12 13 14 15 16 17 18 19 28 29 2A 2B 32 33 43 A0 A1 A2 A3 A4 A5 A6 A7 FD FE FF]
        MMU, NOSWITCHER, NOPO
sim>

This PR modifies cpu_clear() to no longer cause device memory maps
to be removed from the MDEF table when the following CPU commands
are executed.

CPU [NO]BANKED
CPU CLEARMEMORY
CPU [CHIP TYPE]
CPU [MEMORY SIZE]

sim> set jadedd ena
sim> show cpu
CPU
        64KB, NOITRAP, 8080, AZ80, STOPONHALT
        NONBANKED, ALTAIRROM, VERBOSE,
       0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF [16k]
00000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
04000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
08000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
0C000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWMMMMWWWWWWWWWWWWMMMMWWWWWWWWWWWR,
0x[02 03 04 05 08 09 0A 10 11 12 13 14 15 16 17 18 19 28 29 2A 2B 32 33 43 A0 A1 A2 A3 A4 A5 A6 A7 FD FE FF]
        MMU, NOSWITCHER, NOPO
sim> set cpu 24k
sim> show cpu
CPU
        24KB, NOITRAP, 8080, AZ80, STOPONHALT
        NONBANKED, ALTAIRROM, VERBOSE,
       0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF [16k]
00000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW
04000: WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU
08000: UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU
0C000: UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUMMMMUUUUUUUUUUUUMMMMUUUUUUUUUUUR,
0x[02 03 04 05 08 09 0A 10 11 12 13 14 15 16 17 18 19 28 29 2A 2B 32 33 43 A0 A1 A2 A3 A4 A5 A6 A7 FD FE FF]
        MMU, NOSWITCHER, NOPO
sim>
@deltecent deltecent changed the title AltairZ80: device memory maps no longer removed AltairZ80: CPU changes no longer remove device memory maps Jan 13, 2024
@deltecent
Copy link
Contributor Author

Replaced by #347

@deltecent deltecent closed this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant