Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP: Adjust timer calibrations if SET THROTTLE x/t type is enabled #336

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

deltecent
Copy link
Contributor

SCP doesn't initially adjust timer calibrations if SET THROTTLE x/t type is enabled causing large delays in event dispatches. This PR runs the timers through the same calibration adjustment loop as other throttle types.

SCP doesn't initially adjust timer calibrations if SET THROTTLE x/t
type is enabled causing large delays in event dispatches. This PR
runs the timers through the same calibration adjustment loop as
other throttle types.
@deltecent
Copy link
Contributor Author

deltecent commented Dec 30, 2023

A program I was running uses timing loops at boot. SET THROTTLE Xk needs time to calibrate which caused the boot process to fail. @markpizz turned me on to SET THROTTLE x/t which didn't work due to the the event timers getting all out of whack. This PR seems to fix that problem with AltairZ80 simulator when using SET THROTTLE x/y.

If anyone else uses this feature with other simulators, please test.

If anyone sees a better to fix this problem, please do.

Should also fix ^E issue discussed in #318

@deltecent
Copy link
Contributor Author

@markpizz says he is working on a fix for this.

@pkoning2 pkoning2 merged commit 560f30d into open-simh:master Feb 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants