-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send-http-request added #70
Conversation
@SanjayDevTech Thanks for the PR 🤯 Please give us some time to review it 🙏 |
Thank you so much for the PR 🤩. We're adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! 🤯 We left some comments during the review, please check them out.
Would you also please add a README like https://github.com/open-runtimes/examples/blob/1ec5fc25cd5ec71615d44b4ae33214e1d320d25b/kotlin/deepgram-transcribe-audio/README.md?
method = json["method"].toString(), | ||
url = json["url"].toString(), | ||
headers = headers, | ||
body = if (json["method"].toString() != "GET") json["body"].toString() else null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried testing with:
{"headers": {"Content-Type": "application/json"},"url": "https://jsonplaceholder.typicode.com/posts", "method": "POST", "body": "{\"title\": \"foo\"}"}
and
{"headers": {"Content-Type": "application/json"},"url": "https://jsonplaceholder.typicode.com/posts", "method": "POST", "body": {"title": "foo"}}
but I'm getting the following error:
{"success":false,"message":"JSON payload parsing error: com.google.gson.stream.MalformedJsonException: Unterminated object at line 1 column 27 path $."}
Any idea what could be wrong?
Hey there 👋 |
@stnguyen90 Just want to know how to test the functions immediately after the code change? |
@Meldiron Can you re-open this pr. I can't see any option to reopen. Thanks |
Fixes: appwrite/appwrite#4181
sendHTTPRequest()
inkotlin/
folder.