Squashed commit of the following:

commit 471a8b3 Author: Tsavo Knott <tsavo@pieces.app> Date: Fri Jan 3 13:02:16 2025 -0500 Clean Up CI commit 1632820 Author: Tsavo Knott <tsavo@pieces.app> Date: Fri Jan 3 13:00:20 2025 -0500 True Upstream Master commit 1dddfe0 Merge: 774bf81 c9d6286 Author: Tsavo Knott <102485237+tsavo-at-pieces@users.noreply.github.com> Date: Fri Jan 3 12:32:24 2025 -0500 Merge pull request #2 from open-runtime/update-from-upstream Update from Upstream Master commit c9d6286 Merge: 774bf81 9a9c017 Author: Tsavo Knott <tsavo@pieces.app> Date: Fri Jan 3 12:31:33 2025 -0500 Merge branch 'upstream-master' into update-from-upstream commit 774bf81 Merge: 4a043fa 00eabed Author: Tsavo Knott <102485237+tsavo-at-pieces@users.noreply.github.com> Date: Fri Jan 3 12:13:44 2025 -0500 Merge pull request #1 from open-runtime/aot_monorepo_compat Merging AOT Monorepo Compat into our Main Branch commit 9a9c017 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Dec 17 09:58:22 2024 +0100 Bump vm_service from 14.3.1 to 15.0.0 (grpc#751) Bumps [vm_service](https://github.com/dart-lang/sdk/tree/main/pkg) from 14.3.1 to 15.0.0. - [Changelog](https://github.com/dart-lang/sdk/blob/main/CHANGELOG.md) - [Commits](https://github.com/dart-lang/sdk/commits/HEAD/pkg) --- updated-dependencies: - dependency-name: vm_service dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Moritz <mosum@google.com> commit 3e94fec Author: Moritz <mosum@google.com> Date: Tue Dec 17 09:53:02 2024 +0100 Update health.yaml (grpc#753) * Update health.yaml * Upgrade example * Fixes * try different syntax * without endings * test new wf * new version * Works, use main now * Add changelog commit 6676c20 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 16 13:37:35 2024 +0000 Bump dart-lang/setup-dart from 1.6.5 to 1.7.0 (grpc#746) commit f61b9a3 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Nov 4 10:45:05 2024 +0000 Bump actions/checkout from 4.2.0 to 4.2.2 (grpc#744) commit c063010 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 1 08:51:16 2024 +0000 Bump actions/checkout from 4.1.7 to 4.2.0 (grpc#741) commit 04ba68e Author: Moritz <mosum@google.com> Date: Tue Oct 1 04:46:38 2024 -0400 Rev package:lints (grpc#740) * Rev package:lints * Add changelog * Run CI on 3.5.0 * Test with 3.2.0 * Update .github/workflows/dart.yml Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> * Update .github/workflows/dart.yml Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> --------- Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> commit f8bbdce Author: Kevin Moore <kevmoo@users.noreply.github.com> Date: Tue Sep 24 12:07:42 2024 -0700 ignore unreachable_switch_default in weird switch case (grpc#737) commit 071ebc5 Author: steffenhaak <haak@aucentiq.com> Date: Fri Sep 6 17:13:11 2024 +0200 fix: keep alive timeout finishes transport instead of connection shutdown (grpc#722) * fix: keep alive timeout finishes transport instead of shutting down channel * Update keepalive_test.dart * Update CHANGELOG.md --------- Co-authored-by: Moritz <mosum@google.com> commit 8177633 Author: Moritz <mosum@google.com> Date: Fri Sep 6 15:09:54 2024 +0200 Small fixes (grpc#732) * Small fixes * Revert changes on file * Add changelog * Small fixes in keepalive test * Add delay * Fix symbol visibilty * Add try catch for debugging * Fail * fail * Use for loop commit 38ca626 Author: Lasse R.H. Nielsen <lrn@google.com> Date: Mon Sep 2 16:58:43 2024 +0200 Use `Map.of` instead of `Map.from` in grpc client. (grpc#724) * Use `Map.of` instead of `Map.from` in grpc client. `Map.of` creates a new map with the same keys, values and *type* as the original map, when used without type arguments or context type, where `Map.from` creates a `Map<dynamic, dynamic>`. (This code failed on an attempt to make `Map.unmodifiable` be more strictly typed, like `Map.of` instead of `Map.from`, showing that an intermediate map had type `Map<dynamic, dynamic>` unnecessarily). Same for using `List.of` instead of `List.from`. The new code should be (microscopically) more efficient and type safe, and is forwards-compatible with a stronger type on `Map.unmodifiable`. (The code can be optimized more. For example `List.of(list1)..addAll(list2)` can be just `list1 + list2` or `[...list1, ...list2]`, both of which may know the total number of elements when doing the initial list allocation. This is a minimal change to allow the type changes for `.unmodifiable` to get past this very initial blocker in internal tests.) * Add changelog and minor version increment. And my save removes trailing spaces. commit 4f6fe9b Author: c-lucera-pvotal <91328643+c-lucera-pvotal@users.noreply.github.com> Date: Wed Aug 28 08:18:15 2024 +0200 fix: fix headers not completing when call is terminated (grpc#728) Fixes grpc#727 commit c18e185 Author: Kevin Moore <kevmoo@users.noreply.github.com> Date: Wed Jul 24 14:24:57 2024 -0700 Fix status badge (grpc#726) commit b999b64 Author: Galen Warren <galen@cvillewarrens.com> Date: Wed Jul 17 08:11:29 2024 -0400 feat: fix hang that occurs when hot restarting (grpc#718) commit bf8bbde Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jul 1 11:56:47 2024 +0000 Bump dart-lang/setup-dart from 1.6.4 to 1.6.5 (grpc#720) commit 4aa4c8c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jul 1 11:52:08 2024 +0000 Bump actions/checkout from 4.1.6 to 4.1.7 (grpc#719) commit dee1b2b Author: Kevin Moore <kevmoo@users.noreply.github.com> Date: Wed May 29 17:23:53 2024 -0700 Update pubspec.yaml commit 52023d4 Author: Kevin Moore <kevmoo@google.com> Date: Tue May 28 14:47:30 2024 -0700 code fixes commit ebb7368 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed May 22 06:56:00 2024 +0000 Bump lints from 3.0.0 to 4.0.0 Bumps [lints](https://github.com/dart-lang/lints) from 3.0.0 to 4.0.0. - [Release notes](https://github.com/dart-lang/lints/releases) - [Changelog](https://github.com/dart-lang/lints/blob/main/CHANGELOG.md) - [Commits](dart-lang/lints@v3.0.0...v4.0.0) --- updated-dependencies: - dependency-name: lints dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> commit 4e65d4b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 21 11:05:38 2024 +0000 --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> commit 1495453 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 21 11:01:10 2024 +0000 Bump dart-lang/setup-dart from 1.6.2 to 1.6.4 Bumps [dart-lang/setup-dart](https://github.com/dart-lang/setup-dart) from 1.6.2 to 1.6.4. - [Release notes](https://github.com/dart-lang/setup-dart/releases) - [Changelog](https://github.com/dart-lang/setup-dart/blob/main/CHANGELOG.md) - [Commits](dart-lang/setup-dart@fedb126...f0ead98) --- updated-dependencies: - dependency-name: dart-lang/setup-dart dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> commit 6586b74 Author: Sarah Zakarias <zarah@google.com> Date: Tue May 21 12:30:20 2024 +0200 Add `topics` to `pubspec.yaml` (grpc#712) commit 9f65399 Author: Moritz <mosum@google.com> Date: Fri May 17 14:53:33 2024 +0200 Move `codec.dart` to former place (grpc#713) commit 0d02e43 Author: Moritz <mosum@google.com> Date: Mon May 6 06:25:06 2024 -0700 Remove dependency on `package:archive` (grpc#707) * Remove dependency on package:archive * Test compression on vm only * Add licenses * Fix analyze issues * Fix codec web * Fix licenses * Add changelog commit 078fd23 Author: Moritz <mosum@google.com> Date: Thu Apr 25 04:45:40 2024 -0700 Remove generated `StatusCode` (grpc#703) * Remove generated `StatusCode` * Rev version for breaking change * Upgrade min sdk version * Fix issues commit bdbe5f5 Author: Ruben Garcia <RubenGarcia@users.noreply.github.com> Date: Mon Apr 22 16:09:18 2024 +0200 Fix issue 669 (grpc#693) * Fix issue 669 * Update CHANGELOG.md * Update CHANGELOG.md * Fix dart format issue. Fix prefer single quote issue. * Update pubspec and changelog to avoid merge check publish / validate validate packages * Add test for GRPC Compression Flag * Fix dart analyze issues. * Fix latest dart analyze issue (uninizialized variable) commit bb8b6e5 Author: Moritz <mosum@google.com> Date: Fri Apr 19 02:05:59 2024 -0700 Make protobuf generated imports absolute (grpc#696) * Make protobuf generated imports absolute * Stop test for now commit b05fafe Author: Moritz <mosum@google.com> Date: Mon Apr 15 04:43:26 2024 -0700 Add Health workflow (grpc#699) * Add Health workflow * Remove license check commit aece2a4 Author: Abdul Momin <98901875+Curious-x@users.noreply.github.com> Date: Mon Apr 15 12:53:00 2024 +0500 Typo Correction in README.md (grpc#695) Corrected typo "RPs" to "RPCs". To avoid confusion.
open-runtime · Jan 3, 2025 · c533913 · c533913
1 parent 00eabed
commit c533913
Show file tree

Hide file tree

Showing 78 changed files with 948 additions and 722 deletions.
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
@@ -3,11 +3,10 @@ name: Dart
 on:
   # Run CI on pushes to the master branch, and on PRs against master.
   push:
-    branches: [master]
+    branches: [main]
   pull_request:
-    branches: [master]
-  schedule:
-    - cron: "0 0 * * 0"
+    branches: [main]
+  workflow_dispatch:
 
 jobs:
   # Check code formatting and static analysis on a single OS (linux)
@@ -16,10 +15,10 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        sdk: [3.0.0, dev]
+        sdk: [3.5, dev]
     steps:
-      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
-      - uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+      - uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94
         with:
           sdk: ${{ matrix.sdk }}
       - name: Report version
@@ -60,7 +59,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        sdk: [3.0.0, dev]
+        sdk: [3.5, dev]
         platform: [vm, chrome]
         exclude:
           # We only run Chrome tests on Linux. No need to run them
@@ -70,8 +69,8 @@ jobs:
           - os: macos-latest
             platform: chrome
     steps:
-      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
-      - uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+      - uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94
         with:
           sdk: ${{ matrix.sdk }}
       - name: Report version

diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml
@@ -0,0 +1,13 @@
+name: Health
+on:
+  pull_request:
+    branches: [ master ]
+    types: [opened, synchronize, reopened, labeled, unlabeled]
+jobs:
+  health:
+    uses: dart-lang/ecosystem/.github/workflows/health.yaml@main
+    with:
+      checks: "changelog,do-not-submit,breaking,coverage,leaking"
+      ignore_coverage: "example/**,interop/**"
+    permissions:
+      pull-requests: write
diff --git a/.github/workflows/post_summaries.yaml b/.github/workflows/post_summaries.yaml
@@ -0,0 +1,17 @@
+name: Comment on the pull request
+
+on:
+  # Trigger this workflow after the Health workflow completes. This workflow will have permissions to
+  # do things like create comments on the PR, even if the original workflow couldn't.
+  workflow_run:
+    workflows:
+      - Health
+      - Publish
+    types:
+      - completed
+
+jobs:
+  upload:
+    uses: dart-lang/ecosystem/.github/workflows/post_summaries.yaml@main
+    permissions:
+      pull-requests: write
diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,25 @@
+## 4.0.2-wip
+
+* Internal optimization to client code.
+* Small fixes, such as ports in testing and enabling `timeline_test.dart`.
+* When the keep alive manager runs into a timeout, it will finish the transport instead of closing
+  the connection, as defined in the gRPC spec.
+* Upgrade to `package:lints` version 5.0.0 and Dart SDK version 3.5.0.
+* Upgrade `example/grpc-web` code.
+* Update xhr transport to migrate off legacy JS/HTML apis.
+
+## 4.0.1
+
+* Fix header and trailing not completing if the call is terminated. Fixes [#727](https://github.com/grpc/grpc-dart/issues/727)
+
+## 4.0.0
+
+* Set compressed flag correctly for grpc-encoding = identity. Fixes [#669](https://github.com/grpc/grpc-dart/issues/669) (https://github.com/grpc/grpc-dart/pull/693)
+* Remove generated status codes.
+* Remove dependency on `package:archive`.
+* Move `codec.dart`.
+* Work around hang during Flutter hot restart by adding default case handler in _GrpcWebConversionSink.add.
+
 ## 3.2.4
 
 * Forward internal `GrpcError` on when throwing while sending a request.
@@ -19,19 +41,19 @@
 
 ## 3.2.1
 
-* `package:http` now supports more versions: `>=0.13.0 <2.0.0`. 
+* `package:http` now supports more versions: `>=0.13.0 <2.0.0`.
 * `package:protobuf` new supports more versions: `>=2.0.0 <4.0.0`.
 
 ## 3.2.0
 
-* `ChannelOptions` now exposes `connectTimeout`, which is used on the 
+* `ChannelOptions` now exposes `connectTimeout`, which is used on the
   socket connect. This is used to specify the maximum allowed time to wait
   for a connection to be established. If `connectTime` is longer than the system
   level timeout duration, a timeout may occur sooner than specified in
   `connectTimeout`. On timeout, a `SocketException` is thrown.
 * Require Dart 2.17 or greater.
 * Fix issue [#51](https://github.com/grpc/grpc-dart/issues/51), add support for custom error handling.
-* Expose client IP address to server 
+* Expose client IP address to server
 * Add a `channelShutdownHandler` argument to `ClientChannel` and the subclasses.
   This callback can be used to react to channel shutdown or termination.
 * Export the `Code` protobuf enum from the `grpc.dart` library.

diff --git a/README.md b/README.md
@@ -1,14 +1,14 @@
 The [Dart](https://www.dart.dev/) implementation of
 [gRPC](https://grpc.io/): A high performance, open source, general RPC framework that puts mobile and HTTP/2 first.
 
-[![CI status](https://github.com/grpc/grpc-dart/workflows/Dart/badge.svg)](https://github.com/grpc/grpc-dart/actions?query=workflow%3A%22Dart%22+branch%3Amaster)
+[![Dart](https://github.com/grpc/grpc-dart/actions/workflows/dart.yml/badge.svg)](https://github.com/grpc/grpc-dart/actions/workflows/dart.yml)
 [![pub package](https://img.shields.io/pub/v/grpc.svg)](https://pub.dev/packages/grpc)
 
 
 ## Learn more
 
 - [Quick Start](https://grpc.io/docs/languages/dart/quickstart) - get an app running in minutes
-- [Examples](example)
+- [Examples](https://github.com/grpc/grpc-dart/tree/master/example)
 - [API reference](https://grpc.io/docs/languages/dart/api)
 
 For complete documentation, see [Dart gRPC](https://grpc.io/docs/languages/dart).

diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -9,13 +9,15 @@ analyzer:
 
 linter:
   rules:
-    - always_declare_return_types
-    - cancel_subscriptions
-    - close_sinks
-    - directives_ordering
-    - omit_local_variable_types
-    - prefer_final_locals
-    - prefer_single_quotes
-    - test_types_in_equals
-    - use_super_parameters
-    - prefer_relative_imports
+    #true
+    always_declare_return_types: true
+    cancel_subscriptions: true
+    close_sinks: true
+    directives_ordering: true
+    omit_local_variable_types: true
+    prefer_final_locals: true
+    prefer_single_quotes: true
+    test_types_in_equals: true
+    prefer_relative_imports: true
+    #false
+    unintended_html_in_doc_comment: false
diff --git a/example/README.md b/example/README.md
@@ -1,7 +1,7 @@
 Four code examples are available:
 
 1. [helloworld](https://github.com/grpc/grpc-dart/tree/master/example/helloworld):
-   A demonstration of using the Dart gRPC library to perform unary RPs.
+   A demonstration of using the Dart gRPC library to perform unary RPCs.
 
 1. [googleapis](https://github.com/grpc/grpc-dart/tree/master/example/googleapis):
    A demonstration of using the Dart gRPC library to communicate with Google APIs.

diff --git a/example/googleapis/googleapis.iml b/example/googleapis/googleapis.iml
diff --git a/example/googleapis/pubspec_overrides.yaml b/example/googleapis/pubspec_overrides.yaml
diff --git a/example/grpc-web/grpc_web.iml b/example/grpc-web/grpc_web.iml
diff --git a/example/grpc-web/lib/app.dart b/example/grpc-web/lib/app.dart
@@ -1,3 +1,18 @@
+// Copyright (c) 2024, the gRPC project authors. Please see the AUTHORS file
+// for details. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 import 'dart:async';
 import 'dart:html';
 

diff --git a/example/grpc-web/pubspec.yaml b/example/grpc-web/pubspec.yaml
@@ -3,14 +3,14 @@ description: Dart gRPC-Web sample client
 publish_to: none
 
 environment:
-  sdk: '>=2.12.0 <3.0.0'
+  sdk: ^3.5.0
 
 dependencies:
   grpc:
     path: ../../
   protobuf: ^3.0.0
 
 dev_dependencies:
-  build_runner: ^2.0.0
-  build_web_compilers: '>3.0.0 <5.0.0'
-  lints: ^2.0.0
+  build_runner: ^2.4.13
+  build_web_compilers: ^4.0.11
+  lints: ^5.0.0
diff --git a/example/grpc-web/pubspec_overrides.yaml b/example/grpc-web/pubspec_overrides.yaml
diff --git a/example/helloworld/bin/client.dart b/example/helloworld/bin/client.dart
@@ -13,10 +13,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-/// Dart implementation of the gRPC helloworld.Greeter client.
 import 'package:grpc/grpc.dart';
 import 'package:helloworld/src/generated/helloworld.pbgrpc.dart';
 
+/// Dart implementation of the gRPC helloworld.Greeter client.
 Future<void> main(List<String> args) async {
   final channel = ClientChannel(
     'localhost',

diff --git a/example/helloworld/bin/server.dart b/example/helloworld/bin/server.dart
@@ -13,10 +13,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-/// Dart implementation of the gRPC helloworld.Greeter server.
 import 'package:grpc/grpc.dart';
 import 'package:helloworld/src/generated/helloworld.pbgrpc.dart';
 
+/// Dart implementation of the gRPC helloworld.Greeter server.
 class GreeterService extends GreeterServiceBase {
   @override
   Future<HelloReply> sayHello(ServiceCall call, HelloRequest request) async {

diff --git a/example/helloworld/bin/unix_client.dart b/example/helloworld/bin/unix_client.dart
@@ -13,12 +13,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-/// Dart implementation of the gRPC helloworld.Greeter client.
 import 'dart:io';
 
 import 'package:grpc/grpc.dart';
 import 'package:helloworld/src/generated/helloworld.pbgrpc.dart';
 
+/// Dart implementation of the gRPC helloworld.Greeter client.
 Future<void> main(List<String> args) async {
   final udsAddress =
       InternetAddress('localhost', type: InternetAddressType.unix);

diff --git a/example/helloworld/bin/unix_server.dart b/example/helloworld/bin/unix_server.dart
@@ -13,12 +13,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-/// Dart implementation of the gRPC helloworld.Greeter server.
 import 'dart:io';
 
 import 'package:grpc/grpc.dart';
 import 'package:helloworld/src/generated/helloworld.pbgrpc.dart';
 
+/// Dart implementation of the gRPC helloworld.Greeter server.
 class GreeterService extends GreeterServiceBase {
   @override
   Future<HelloReply> sayHello(ServiceCall call, HelloRequest request) async {

diff --git a/example/helloworld/helloworld.iml b/example/helloworld/helloworld.iml
diff --git a/example/helloworld/pubspec_overrides.yaml b/example/helloworld/pubspec_overrides.yaml
diff --git a/example/metadata/metadata.iml b/example/metadata/metadata.iml
diff --git a/example/metadata/pubspec_overrides.yaml b/example/metadata/pubspec_overrides.yaml
diff --git a/example/route_guide/pubspec_overrides.yaml b/example/route_guide/pubspec_overrides.yaml