ast/parser: guard against invalid domains for "some" and "every" #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would cause a runtime exception when attempting to parse
some internal.member_2()
This is due to a technicality in how
some x in xs
is parsed: `x in xs` will first become `internal.member_2(x, xs)`,
and `some internal.member_2(x, xs)` is then further processed. The
assumption that there're always two (resp. three for internal.member_3)
arguments won't hold if a snippet like the one above is fed into
the parser.
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
anderseknert
approved these changes
Apr 5, 2022
rokkiter
pushed a commit
to rokkiter/opa
that referenced
this pull request
Apr 18, 2022
…n-policy-agent#4548) These would cause a runtime exception when attempting to parse some internal.member_2() This is due to a technicality in how some x in xs is parsed: `x in xs` will first become `internal.member_2(x, xs)`, and `some internal.member_2(x, xs)` is then further processed. The assumption that there're always two (resp. three for internal.member_3) arguments won't hold if a snippet like the one above is fed into the parser. Thanks to Norbert Szetei of Doyensec, @doyensec, for reporting this. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These would cause a runtime exception when attempting to parse
This is due to a technicality in how
is parsed:
x in xswill first becomeinternal.member_2(x, xs),and
some internal.member_2(x, xs)is then further processed. Theassumption that there're always two (resp. three for internal.member_3)
arguments won't hold if a snippet like the one above is fed into
the parser.
Thanks to Norbert Szetei of Doyensec, @doyensec, for reporting this.