rego+topdown: allow custom builtins via rego pkg to halt #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, functions provided via arguments to `rego.New()` hadn't been able to halt the topdown evaluation. Now, they do, if they return a `*rego.HaltError`. Fixes open-policy-agent#3534. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
tsandall
approved these changes
Jul 13, 2021
dolevf
pushed a commit
to dolevf/opa
that referenced
this pull request
Nov 4, 2021
…-agent#3645) Before, functions provided via arguments to `rego.New()` hadn't been able to halt the topdown evaluation. Now, they do, if they return a `*rego.HaltError`. Fixes open-policy-agent#3534. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com> Signed-off-by: Dolev Farhi <farhi.dolev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, functions provided via arguments to
rego.New()hadn't beenable to halt the topdown evaluation.
Now, they do, if they return a
*rego.HaltError.Fixes #3534.