Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partial eval: invalidate cache when data changes #589

Closed
tsandall opened this issue Jan 31, 2018 · 2 comments
Closed

partial eval: invalidate cache when data changes #589

tsandall opened this issue Jan 31, 2018 · 2 comments

Comments

@tsandall
Copy link
Member

The OPA server should invalidate the partial evaluation cache whenever data changes. In the short term it would be acceptable to invalidate on ANY data change. In the future, we should use the dependency analysis implementation to perform more fine-grained invalidation.
@tsandall tsandall changed the title Invalidate partial evaluation cache whenever data changes partial eval: invalidate cache when data changes Feb 19, 2018
tsandall added a commit to tsandall/opa that referenced this issue Jun 4, 2018
@tsandall
Fix partial cache invalidation for data changes
e186bcc 
The partial cache was not be invalidated when data changed. As a result,
callers would receive stale results when data updated.

Fixes open-policy-agent#589

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
@tsandall tsandall mentioned this issue Jun 4, 2018
Merged
tsandall added a commit that referenced this issue Jun 4, 2018
@tsandall
Fix partial cache invalidation for data changes
c19e342 
The partial cache was not be invalidated when data changed. As a result,
callers would receive stale results when data updated.

Fixes #589

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
@srenatus
Copy link
Contributor

In the future, we should use the dependency analysis implementation to perform more fine-grained invalidation.

@tsandall Is this still on the table? 😃 (Just curious, really, no immediate needs)

@tsandall
Copy link
Member Author

It's still on the table, but I think we should wait before committing to working on it. Tracking the dependencies and only limiting the scope of evaluation is interesting but it feels like a hard problem to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsandall @srenatus