Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused data from the YAML test suite files #4813

Closed
anderseknert opened this issue Jun 27, 2022 · 0 comments · Fixed by #4817
Closed

Remove unused data from the YAML test suite files #4813

anderseknert opened this issue Jun 27, 2022 · 0 comments · Fixed by #4817

Comments

@anderseknert
Copy link
Member

Due to a migration in the past (I think), most of the YAML test files contain data which aren't used in the tests. This is confusing to new contributors, annoying for everybody... and with external projects starting to use the test suite for e.g. compliance testing of IR implementations, this cruft is no longer just an internal concern. In order to improve this, we should purge the YAML files from any data not used by the tests in that file.
@anderseknert anderseknert mentioned this issue Jun 27, 2022
Merged
anderseknert added a commit to anderseknert/opa that referenced this issue Jun 27, 2022
@anderseknert
Remove any data attrubutes not used in the "YAML tests"
d646276 
Fixes open-policy-agent#4813

Signed-off-by: Anders Eknert <anders@eknert.com>
srenatus pushed a commit that referenced this issue Jun 28, 2022
@anderseknert
Remove any data attrubutes not used in the "YAML tests" (#4817)
dfd4be4 
Fixes #4813

Signed-off-by: Anders Eknert <anders@eknert.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove any data attributes not used in the "YAML tests" anderseknert/opa
1 participant
@anderseknert