Regression with v0.29.4 and console decision logger being tied to general log level #3654
Assignees
Labels
Comments
tsandall
added a commit
to tsandall/opa
that referenced
this issue
Jul 27, 2021
This commit fixes the console loggers so that messages are emitted regardless of the debug log level. The problem was that in 3fcc875 we updated the plugins to use a console logger obtained from the plugin manager as opposed to a global logger instantiated in the plugins package--the console logger obtained from the plugin manager was instantiated in the runtime package by calling logging.NewStandardLogger. Unfortunately, logging.NewStandardLogger does not create a new logger--it returns the global logrus logger. This commit fixes the issue by deprecating logging.NewStandardLogger and introducing two new functions in the logging package: * logging.Get() - this replaces the old logging.NewStandardLogger function--this function should be called to obtain the debug logger used throughout OPA. * logging.New() - this actually returns a new logger that can be configured independently from the debug logger used throughout OPA. The runtime and sdk packages have been updated to call logging.New() to obtain console loggers and the rest of the codebase has been updated to call logging.Get() in place of logging.NewStandardLogger(). Fixes open-policy-agent#3654 Signed-off-by: Torin Sandall <torinsandall@gmail.com>
tsandall
added a commit
that referenced
this issue
Jul 27, 2021
This commit fixes the console loggers so that messages are emitted regardless of the debug log level. The problem was that in 3fcc875 we updated the plugins to use a console logger obtained from the plugin manager as opposed to a global logger instantiated in the plugins package--the console logger obtained from the plugin manager was instantiated in the runtime package by calling logging.NewStandardLogger. Unfortunately, logging.NewStandardLogger does not create a new logger--it returns the global logrus logger. This commit fixes the issue by deprecating logging.NewStandardLogger and introducing two new functions in the logging package: * logging.Get() - this replaces the old logging.NewStandardLogger function--this function should be called to obtain the debug logger used throughout OPA. * logging.New() - this actually returns a new logger that can be configured independently from the debug logger used throughout OPA. The runtime and sdk packages have been updated to call logging.New() to obtain console loggers and the rest of the codebase has been updated to call logging.Get() in place of logging.NewStandardLogger(). Fixes #3654 Signed-off-by: Torin Sandall <torinsandall@gmail.com>
dolevf
pushed a commit
to dolevf/opa
that referenced
this issue
Nov 4, 2021
This commit fixes the console loggers so that messages are emitted regardless of the debug log level. The problem was that in 3fcc875 we updated the plugins to use a console logger obtained from the plugin manager as opposed to a global logger instantiated in the plugins package--the console logger obtained from the plugin manager was instantiated in the runtime package by calling logging.NewStandardLogger. Unfortunately, logging.NewStandardLogger does not create a new logger--it returns the global logrus logger. This commit fixes the issue by deprecating logging.NewStandardLogger and introducing two new functions in the logging package: * logging.Get() - this replaces the old logging.NewStandardLogger function--this function should be called to obtain the debug logger used throughout OPA. * logging.New() - this actually returns a new logger that can be configured independently from the debug logger used throughout OPA. The runtime and sdk packages have been updated to call logging.New() to obtain console loggers and the rest of the codebase has been updated to call logging.Get() in place of logging.NewStandardLogger(). Fixes open-policy-agent#3654 Signed-off-by: Torin Sandall <torinsandall@gmail.com> Signed-off-by: Dolev Farhi <farhi.dolev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As recently as v0.28.0 the console decision logger was decoupled from the general log level (by design). With v0.29.4 that's no longer the case. For example, w/ v0.28.0 this works fine:
In another terminal run
curl localhost:8181/v1/data/system/version. Observe the log below:With v0.29.4 no log gets emitted. I'm guessing the SDK changes are to blame.
The text was updated successfully, but these errors were encountered: