Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opa test timeout is for full opa test run and not per test case #1788

Closed
patrick-east opened this issue Sep 23, 2019 · 0 comments · Fixed by #1851
Closed

opa test timeout is for full opa test run and not per test case #1788

patrick-east opened this issue Sep 23, 2019 · 0 comments · Fixed by #1851

Comments

@patrick-east
Copy link
Contributor

The timeout given to opa test gives the impression that it is per-test when it is really for the entire test run. This means that as test suites get larger the --timeout parameter must be increased to scale with it.. which shouldn't really be the case.

What I would propose is to make the --timeout be on a per-test basis so that it can scale better as larger policy libraries are developed and tested. As I understand the idea behind the timeout flag was to just prevent tests from hanging or taking too long, so this should still fulfill the original use-case.
@patrick-east patrick-east changed the title opa test timeout is for full test run and not per test opa test timeout is for full opa test run and not per test case Sep 23, 2019
Blokje5 added a commit to Blokje5/opa that referenced this issue Oct 20, 2019
@Blokje5
Implement the test timeout at individual test level to make it easier…
0ccccdb 
… to scale rego test when using the --timeout flag.

Fixes open-policy-agent#1788

Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>
@Blokje5 Blokje5 mentioned this issue Oct 20, 2019
Merged
patrick-east pushed a commit that referenced this issue Oct 22, 2019
@Blokje5 @patrick-east
Implement the test timeout at individual test level to make it easier…
3c34d13 
… to scale rego test when using the --timeout flag.

Fixes #1788

Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>
@tsandall tsandall mentioned this issue Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Timeout flag on individual test cases in opa test command Blokje5/opa
1 participant
@patrick-east