Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ns exclusion audit from cache (#3129) cherry-pick for 3.13 #3140

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Nov 1, 2023

cherry pick of #3129 for 3.13

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
@acpana acpana marked this pull request as draft November 1, 2023 18:09
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d767834) 53.16% compared to head (8cd3a41) 53.57%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-3.13    #3140      +/-   ##
================================================
+ Coverage         53.16%   53.57%   +0.40%     
================================================
  Files               135      135              
  Lines             11801    11808       +7     
================================================
+ Hits               6274     6326      +52     
+ Misses             5045     4991      -54     
- Partials            482      491       +9     
Flag Coverage Δ
unittests 53.57% <57.14%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/audit/manager.go 13.95% <57.14%> (+4.11%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acpana acpana marked this pull request as ready for review November 1, 2023 18:25
@sozercan
Copy link
Member

sozercan commented Nov 1, 2023

@acpana do we want to do this for 3.14 too?

@sozercan sozercan merged commit 72364ad into open-policy-agent:release-3.13 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants