Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: examples, fix:improve gator err msg #3079

Merged
merged 4 commits into from
Oct 23, 2023
Merged

docs: examples, fix:improve gator err msg #3079

merged 4 commits into from
Oct 23, 2023

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Oct 17, 2023

fixes #3059

@acpana
docs: examples, enh:improve ar err msg
23fb88c 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f58c5a8) 52.46% compared to head (b65582b) 52.45%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3079      +/-   ##
==========================================
- Coverage   52.46%   52.45%   -0.02%     
==========================================
  Files         134      134              
  Lines       11952    11952              
==========================================
- Hits         6271     6269       -2     
- Misses       5190     5191       +1     
- Partials      491      492       +1
Flag Coverage Δ
unittests 52.45% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/gator/verify/runner.go 84.75% <100.00%> (ø)
pkg/util/request_validation.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acpana acpana marked this pull request as ready for review October 17, 2023 23:20
@maxsmythe maxsmythe changed the title docs: examples, enh:improve ar err msg docs: examples, fix:improve ar err msg Oct 18, 2023
@maxsmythe maxsmythe changed the title docs: examples, fix:improve ar err msg docs: examples, fix:improve gator err msg Oct 18, 2023
@acpana
change errs
0303d83 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@acpana acpana requested a review from maxsmythe October 19, 2023 22:37
maxsmythe
maxsmythe approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@acpana acpana requested a review from ritazh October 23, 2023 19:42
ritazh
ritazh approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR!

@acpana acpana merged commit 1f6cd33 into open-policy-agent:master Oct 23, 2023
Mattes83 pushed a commit to Mattes83/gatekeeper that referenced this pull request Oct 25, 2023
@acpana @Mattes83
docs: examples, fix:improve gator err msg (open-policy-agent#3079)
f4edfd0 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritazh ritazh ritazh approved these changes

@maxsmythe maxsmythe maxsmythe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gator cannot test DELETE operations
4 participants
@acpana @codecov-commenter @ritazh @maxsmythe