-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: drop arm/v7 builds for crd image #3074
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3074 +/- ##
==========================================
+ Coverage 52.42% 52.50% +0.07%
==========================================
Files 134 134
Lines 11952 11952
==========================================
+ Hits 6266 6275 +9
+ Misses 5193 5187 -6
+ Partials 493 490 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
What this PR does / why we need it:
registry.k8s.io/kubectl:v1.28.2
does not include 32-bit arm/v7 kubectl, which blocks us from building gatekeeper-crds image for arm/v7Also fixes a bug in the pre-release CI where we omitted
\
, this should have been caught thereWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer:
This is blocking v3.14.0 release so needs to be cherry picked there after merge