-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Prepare v3.14.0-beta.0 release #2935
Conversation
c0d56d6
to
6b54bb7
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2935 +/- ##
=======================================
Coverage 53.10% 53.10%
=======================================
Files 135 135
Lines 11806 11806
=======================================
Hits 6269 6269
Misses 5051 5051
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
6b54bb7
to
1866040
Compare
Co-authored-by: sozercan <sozercan@users.noreply.github.com>
@@ -36,10 +36,44 @@ Adds additional pod labels to the common ones | |||
*/}} | |||
{{- define "gatekeeper.podLabels" -}} | |||
{{- if .Values.podLabels }} | |||
{{- toYaml .Values.podLabels | nindent 8 }} | |||
{{- toYaml .Values.podLabels }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sozercan this change seems to break the chart rendering when podLabels
is set in values.
Error: YAML parse error on gatekeeper/templates/gatekeeper-audit-deployment.yaml: error converting YAML to JSON: yaml: line 32: mapping values are not allowed in this context helm.go:84: [debug] error converting YAML to JSON: yaml: line 32: mapping values are not allowed in this context
rendered snippet with invalid yaml due to indentation issue:
.....
template:
metadata:
annotations:
prometheus.io/port: "8888"
prometheus.io/scrape: "true"
labels:policyengine: opa <======== podLabels
app: 'gatekeeper'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, fixed in #3153. Waiting on next 3.14.x release.
Automated changes by create-pull-request GitHub action