Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prepare v3.14.0-beta.0 release #2935

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 8, 2023

Automated changes by create-pull-request GitHub action

@sozercan sozercan force-pushed the release-v3.14.0-beta.0 branch from c0d56d6 to 6b54bb7 Compare August 9, 2023 02:30
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5c49294) 53.10% compared to head (6b54bb7) 53.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2935   +/-   ##
=======================================
  Coverage   53.10%   53.10%           
=======================================
  Files         135      135           
  Lines       11806    11806           
=======================================
  Hits         6269     6269           
  Misses       5051     5051           
  Partials      486      486           
Flag Coverage Δ
unittests 53.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan force-pushed the release-v3.14.0-beta.0 branch from 6b54bb7 to 1866040 Compare August 9, 2023 17:50
@sozercan sozercan merged commit cf867d1 into master Aug 9, 2023
@sozercan sozercan deleted the release-v3.14.0-beta.0 branch August 9, 2023 18:49
salaxander pushed a commit to salaxander/gatekeeper that referenced this pull request Sep 13, 2023
Co-authored-by: sozercan <sozercan@users.noreply.github.com>
@@ -36,10 +36,44 @@ Adds additional pod labels to the common ones
*/}}
{{- define "gatekeeper.podLabels" -}}
{{- if .Values.podLabels }}
{{- toYaml .Values.podLabels | nindent 8 }}
{{- toYaml .Values.podLabels }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sozercan this change seems to break the chart rendering when podLabels is set in values.

Error: YAML parse error on gatekeeper/templates/gatekeeper-audit-deployment.yaml: error converting YAML to JSON: yaml: line 32: mapping values are not allowed in this context helm.go:84: [debug] error converting YAML to JSON: yaml: line 32: mapping values are not allowed in this context
rendered snippet with invalid yaml due to indentation issue:

.....
 template:
    metadata:
      annotations:
        prometheus.io/port: "8888"
        prometheus.io/scrape: "true"
      labels:policyengine: opa         <======== podLabels
        app: 'gatekeeper'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, fixed in #3153. Waiting on next 3.14.x release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants