Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump kubectl #2624

Merged
merged 3 commits into from
Mar 18, 2023
Merged

chore: bump kubectl #2624

merged 3 commits into from
Mar 18, 2023

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Mar 15, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@ritazh
Copy link
Member Author

ritazh commented Mar 15, 2023

Unit test was failing when setting KUBERNETES_VERSION to 1.26.2

unable to fetch checksum for requested version: unable fetch metadata for kubebuilder-tools-1.26.2-linux-amd64.tar.gz -- got status "404 Not Found" from GCS

Seems even with the latest envtest sigs.k8s.io/controller-runtime/tools/setup-envtest@latest, it does not support 1.26.2 yet. Since we only need 1.26.2 for kubectl for the gatekeeper-crds image, I'm adding CRD_KUBECTL_VERSION just for that image so we don't break unit test. WDYT? @sozercan @maxsmythe

@sozercan
Copy link
Member

sozercan commented Mar 15, 2023

LGTM, once kubernetes-sigs/kubebuilder#3301 merges and new artifacts are in storage, we can revert this

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ritazh and others added 2 commits March 17, 2023 16:39
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@ritazh ritazh merged commit ada84ab into open-policy-agent:master Mar 18, 2023
@ritazh ritazh deleted the bump-kubectl branch March 18, 2023 00:13
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 23, 2023
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
salaxander pushed a commit to salaxander/gatekeeper that referenced this pull request Apr 5, 2023
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants