Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CF to fix unenforced violations on data deletion #2038

Merged
merged 1 commit into from
May 4, 2022

Conversation

maxsmythe
Copy link
Contributor

Fixes #1783

Signed-off-by: Max Smythe smythe@google.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Fixes open-policy-agent#1783

Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe maxsmythe requested a review from sozercan May 4, 2022 22:29
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #2038 (dfadf17) into master (2cf079a) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
+ Coverage   54.38%   54.44%   +0.05%     
==========================================
  Files         110      110              
  Lines        9434     9434              
==========================================
+ Hits         5131     5136       +5     
+ Misses       3915     3912       -3     
+ Partials      388      386       -2     
Flag Coverage Δ
unittests 54.44% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/readiness/list.go 79.41% <0.00%> (-11.77%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 57.31% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab09c7...dfadf17. Read the comment docs.

@maxsmythe maxsmythe merged commit e835348 into open-policy-agent:master May 4, 2022
@sozercan
Copy link
Member

sozercan commented May 5, 2022

davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Jul 19, 2022
…agent#2038)

Fixes open-policy-agent#1783

Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to see violations in constraints.
3 participants