-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run tests with --race enabled #1944
ci: run tests with --race enabled #1944
Conversation
Signed-off-by: mozillazg <mozillazg101@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1944 +/- ##
==========================================
+ Coverage 54.22% 54.30% +0.08%
==========================================
Files 106 106
Lines 9441 9441
==========================================
+ Hits 5119 5127 +8
+ Misses 3933 3927 -6
+ Partials 389 387 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice! Glad we've fixed the race conditions! |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1929
Special notes for your reviewer:
Depend on #1941 #1942 #1943