Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests with --race enabled #1944

Merged
merged 4 commits into from
Apr 6, 2022

Conversation

mozillazg
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1929

Special notes for your reviewer:

Depend on #1941 #1942 #1943

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #1944 (721d4ef) into master (c88d1ab) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1944      +/-   ##
==========================================
+ Coverage   54.22%   54.30%   +0.08%     
==========================================
  Files         106      106              
  Lines        9441     9441              
==========================================
+ Hits         5119     5127       +8     
+ Misses       3933     3927       -6     
+ Partials      389      387       -2     
Flag Coverage Δ
unittests 54.30% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 57.07% <0.00%> (+0.23%) ⬆️
pkg/readiness/object_tracker.go 83.98% <0.00%> (+1.06%) ⬆️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88d1ab...721d4ef. Read the comment docs.

@mozillazg mozillazg marked this pull request as ready for review April 1, 2022 14:38
@mozillazg
Copy link
Contributor Author

Ready for review.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sozercan sozercan modified the milestone: v3.8.0 Apr 1, 2022
@sozercan sozercan requested a review from a team April 6, 2022 00:43
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willbeason
Copy link
Member

Nice! Glad we've fixed the race conditions!

@willbeason willbeason merged commit 3f964bb into open-policy-agent:master Apr 6, 2022
@sozercan sozercan mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race conditions in gatekeeper detected with "go test ./... --race"
6 participants