Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update externaldata storage version #300

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Mar 2, 2023

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan requested review from maxsmythe and ritazh March 2, 2023 22:24
@sozercan sozercan mentioned this pull request Mar 2, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (777dc99) 49.30% compared to head (42eb21b) 49.30%.

❗ Current head 42eb21b differs from pull request most recent head 778cb23. Consider uploading reports for the commit 778cb23 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   49.30%   49.30%           
=======================================
  Files          69       69           
  Lines        4468     4468           
=======================================
  Hits         2203     2203           
  Misses       2021     2021           
  Partials      244      244           
Flag Coverage Δ
unittests 49.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/pkg/apis/externaldata/v1beta1/provider_types.go 100.00% <0.00%> (ø)
...t/pkg/apis/externaldata/v1alpha1/provider_types.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 98638c6 into open-policy-agent:master Mar 3, 2023
@sozercan sozercan deleted the chore-update-externaldata-storage-version branch March 3, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants