perf: Remove with statement to avoid deepcopying data.inventory
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Smythe <smythe@google.com>
Codecov ReportBase: 50.30% // Head: 50.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 50.30% 50.30%
=======================================
Files 64 64
Lines 4266 4266
=======================================
Hits 2146 2146
Misses 1881 1881
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@ritazh @sozercan We ran the numbers for |
ritazh
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for open-policy-agent/gatekeeper#2283
Digging through the OPA code, the
withstatement triggers a deepcopy of the referenced data. With the new execution model implemented for performance improvements, this deepcopy would be run multiple times, which could mean significant CPU overhead and unnecessary memory usage.Not using the
withkey would make it harder to mask out only resources in specific namespaces if we ever create namespace-scoped constraint templates, but should not hurt near-term functionality.It may be we will need an alternative method for accessing the data cache if we need to mask visibility in the future.
Signed-off-by: Max Smythe smythe@google.com