OSC-RDMA: PSCW fix #9556
Merged
OSC-RDMA: PSCW fix #9556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwbarrett
approved these changes
Oct 19, 2021
devreal
approved these changes
Oct 19, 2021
devreal
requested changes
Oct 19, 2021
| @@ -456,6 +456,11 @@ int ompi_osc_rdma_complete_atomic (ompi_win_t *win) | |||
| OSC_RDMA_VERBOSE(MCA_BASE_VERBOSE_TRACE, "complete: %s", win->w_name); | |||
|
|
|||
| OPAL_THREAD_LOCK(&module->lock); | |||
| if (0 == ompi_group_size (sync->sync.pscw.group)) { | |||
There was a problem hiding this comment.
Wait! The group is not retained if it is empty. Use the sync->num_peers instead, it's properly set in ompi_osc_rdma_start_atomic
related to open-mpi#9540 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
f248e09 to
e20108c
Compare
devreal
approved these changes
Oct 19, 2021
|
bot:ompi:retest |
|
@hjelmn this is a customer reported problem. please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #9540
Signed-off-by: Howard Pritchard howardp@lanl.gov