v4.0.x: btl/vader: don't try to set reachabilty in add_procs if not requested #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where add_procs can incorrectly return an error when going through the dynamic add_procs path. This doesn't happen normally, only when pml/ob1 is not in use. References open-mpi#6201 Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 30b8336)
|
@jsquyres Fairly straightforward. In the dynamic add_procs case reachabilty is always NULL so we don't want to return an error in this case. This bug flew under the radar until I added atomic support to vader. |
jsquyres
approved these changes
Jan 7, 2019
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit edaf08b)
|
@jsquyres Addressed your comment with the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where add_procs can incorrectly return an
error when going through the dynamic add_procs path. This doesn't
happen normally, only when pml/ob1 is not in use.
References #6201
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
(cherry picked from commit 30b8336)