mpi/neighbor_allgatherv: fix copy&paste error and add helpers #3865
Conversation
This commit adds a helper function to get the inbound and outbound neighbor count and updates the neighbor_allgatherv bindings to use the correct count when checking the input parameters. Fixes open-mpi#2324 Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 3c0e94a) Signed-off-by: Nathan Hjelm <hjelmn@me.com>
|
The IBM CI (GNU Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/347c18eb4b0e667faeb05fbd0f1144af |
96edde5 to
e1764ac
Compare
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/3d6240b77cedd336f6a97f2d1a66d356 |
|
@ggouaillardet Can you review this PR? Thanks! |
|
@hjelmn could you respond to @ggouaillardet comment about 9b702fb |
|
@jsquyres should we close this? |
|
I just pinged @hjelmn again. It looks like it's an actual bug fix...? |
|
@hjelmn let's try and fix this. Please check by COB this thursday. |
|
@ggouaillardet please review. we want to get this in for 2.0.4, which we would like to start roll out this week. |
|
@hppritcha i did already review this PR, and my review was
if the mentioned commit does not require being cherry-picked, then i am fine with this PR |
This commit removes the communicator topo helper functions in favor of functions in mca/topo/base. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 9b702fb)
|
The IBM CI (GNU Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/8bce83bcb32a46bb4ef9b4bc977f7cab |
|
All Tests Passed! |
|
IBM Jenkins hit a github API rate limit; Josh was going to let it timeout / get more API credits and then re-kick off the IBM Jenkins. |
|
fwiw, the github API rate limit is pretty low for unauthenticated requests (and i guess things get even worse if you are behind a large corporate proxy), but the github API rate limit seems very acceptable for authenticated requests. |
|
bot:ibm:retest |
|
There is something else wrong with the Jenkins server that's causing it to fail out. Hopefully I'll find time this week to fix it. Otherwise... |
|
IBM's CI is temporarily down. Merging this PR. |
This commit adds a helper function to get the inbound and outbound
neighbor count and updates the neighbor_allgatherv bindings to use the
correct count when checking the input parameters.
Fixes #2324
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
(cherry picked from commit 3c0e94a)
Signed-off-by: Nathan Hjelm hjelmn@me.com