Ensure that we always send a SIGTERM prior to SIGKILL to give child processes a chance to cleanup #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocesses a chance to cleanup Thanks to Noel Rycroft for the report Signed-off-by: Ralph Castain <rhc@open-mpi.org>
|
Replaces #2496 |
|
bot:lanl:retest |
bwbarrett
added a commit
to bwbarrett/ompi
that referenced
this pull request
Mar 25, 2022
PMIx Changes: fbc2513 build: Delay adding DELAYED_LIBS even more a83d564 Minor correction to client-get logic 4aa95ff In the case where the server is using a different dstore component, check that as well. 8a41b35 Remove the "<option> help" support 76850f6 Fix signed comparison warning 65df23e Ensure we check peer's gds for data b13e7d4 Silence Coverity warning 2a34472 build: Clean up delayed flags a1a5935 build: Use MCA env management for common/sse e15de4b build: Wrapper/pkg-config improvements 680326c build: check_package static improvements 330d2d4 Merge pull request open-mpi#2529 from bwbarrett/bugfix/summary_stream a819eeb build: Fix output stream bug in summary PRRTE Changes: c49eafc3ac Protect against proxy confusion 86bddb2abf Add some missing help verbiage 4e9029ccea slurm: fix breakage owing to rlm refactor 514553dedf Correctly determine when to daemonize backend prted 0db143da11 Some really minor cleanups c784c22947 build: check_package static improvements e0810859d7 Add missing CLI option and parsing a9e2303807 Merge pull request open-mpi#1292 from bwbarrett/bugfix/summary_stream 94b57788ca Merge pull request open-mpi#1291 from rhc54/topic/py fabb57117b build: Fix output stream bug in summary 17e6d86cbf Fix a problem with the "canonicalize_path" function Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
added a commit
to bwbarrett/ompi
that referenced
this pull request
Mar 26, 2022
PMIx Changes: fbc2513 build: Delay adding DELAYED_LIBS even more a83d564 Minor correction to client-get logic 4aa95ff In the case where the server is using a different dstore component, check that as well. 8a41b35 Remove the "<option> help" support 76850f6 Fix signed comparison warning 65df23e Ensure we check peer's gds for data b13e7d4 Silence Coverity warning 2a34472 build: Clean up delayed flags a1a5935 build: Use MCA env management for common/sse e15de4b build: Wrapper/pkg-config improvements 680326c build: check_package static improvements 330d2d4 Merge pull request open-mpi#2529 from bwbarrett/bugfix/summary_stream a819eeb build: Fix output stream bug in summary PRRTE Changes: c49eafc3ac Protect against proxy confusion 86bddb2abf Add some missing help verbiage 4e9029ccea slurm: fix breakage owing to rlm refactor 514553dedf Correctly determine when to daemonize backend prted 0db143da11 Some really minor cleanups c784c22947 build: check_package static improvements e0810859d7 Add missing CLI option and parsing a9e2303807 Merge pull request open-mpi#1292 from bwbarrett/bugfix/summary_stream 94b57788ca Merge pull request open-mpi#1291 from rhc54/topic/py fabb57117b build: Fix output stream bug in summary 17e6d86cbf Fix a problem with the "canonicalize_path" function Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
added a commit
to bwbarrett/ompi
that referenced
this pull request
Mar 28, 2022
PMIx Changes: fbc2513 build: Delay adding DELAYED_LIBS even more a83d564 Minor correction to client-get logic 4aa95ff In the case where the server is using a different dstore component, check that as well. 8a41b35 Remove the "<option> help" support 76850f6 Fix signed comparison warning 65df23e Ensure we check peer's gds for data b13e7d4 Silence Coverity warning 2a34472 build: Clean up delayed flags a1a5935 build: Use MCA env management for common/sse e15de4b build: Wrapper/pkg-config improvements 680326c build: check_package static improvements 330d2d4 Merge pull request open-mpi#2529 from bwbarrett/bugfix/summary_stream a819eeb build: Fix output stream bug in summary PRRTE Changes: c49eafc3ac Protect against proxy confusion 86bddb2abf Add some missing help verbiage 4e9029ccea slurm: fix breakage owing to rlm refactor 514553dedf Correctly determine when to daemonize backend prted 0db143da11 Some really minor cleanups c784c22947 build: check_package static improvements e0810859d7 Add missing CLI option and parsing a9e2303807 Merge pull request open-mpi#1292 from bwbarrett/bugfix/summary_stream 94b57788ca Merge pull request open-mpi#1291 from rhc54/topic/py fabb57117b build: Fix output stream bug in summary 17e6d86cbf Fix a problem with the "canonicalize_path" function Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
added a commit
to bwbarrett/ompi
that referenced
this pull request
Mar 29, 2022
PMIx Changes: fbc2513 build: Delay adding DELAYED_LIBS even more a83d564 Minor correction to client-get logic 4aa95ff In the case where the server is using a different dstore component, check that as well. 8a41b35 Remove the "<option> help" support 76850f6 Fix signed comparison warning 65df23e Ensure we check peer's gds for data b13e7d4 Silence Coverity warning 2a34472 build: Clean up delayed flags a1a5935 build: Use MCA env management for common/sse e15de4b build: Wrapper/pkg-config improvements 680326c build: check_package static improvements 330d2d4 Merge pull request open-mpi#2529 from bwbarrett/bugfix/summary_stream a819eeb build: Fix output stream bug in summary PRRTE Changes: c49eafc3ac Protect against proxy confusion 86bddb2abf Add some missing help verbiage 4e9029ccea slurm: fix breakage owing to rlm refactor 514553dedf Correctly determine when to daemonize backend prted 0db143da11 Some really minor cleanups c784c22947 build: check_package static improvements e0810859d7 Add missing CLI option and parsing a9e2303807 Merge pull request open-mpi#1292 from bwbarrett/bugfix/summary_stream 94b57788ca Merge pull request open-mpi#1291 from rhc54/topic/py fabb57117b build: Fix output stream bug in summary 17e6d86cbf Fix a problem with the "canonicalize_path" function Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
added a commit
to bwbarrett/ompi
that referenced
this pull request
Mar 30, 2022
PMIx Changes: fbc2513 build: Delay adding DELAYED_LIBS even more a83d564 Minor correction to client-get logic 4aa95ff In the case where the server is using a different dstore component, check that as well. 8a41b35 Remove the "<option> help" support 76850f6 Fix signed comparison warning 65df23e Ensure we check peer's gds for data b13e7d4 Silence Coverity warning 2a34472 build: Clean up delayed flags a1a5935 build: Use MCA env management for common/sse e15de4b build: Wrapper/pkg-config improvements 680326c build: check_package static improvements 330d2d4 Merge pull request open-mpi#2529 from bwbarrett/bugfix/summary_stream a819eeb build: Fix output stream bug in summary PRRTE Changes: c49eafc3ac Protect against proxy confusion 86bddb2abf Add some missing help verbiage 4e9029ccea slurm: fix breakage owing to rlm refactor 514553dedf Correctly determine when to daemonize backend prted 0db143da11 Some really minor cleanups c784c22947 build: check_package static improvements e0810859d7 Add missing CLI option and parsing a9e2303807 Merge pull request open-mpi#1292 from bwbarrett/bugfix/summary_stream 94b57788ca Merge pull request open-mpi#1291 from rhc54/topic/py fabb57117b build: Fix output stream bug in summary 17e6d86cbf Fix a problem with the "canonicalize_path" function Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
added a commit
to bwbarrett/ompi
that referenced
this pull request
Mar 30, 2022
PMIx Changes: fbc2513 build: Delay adding DELAYED_LIBS even more a83d564 Minor correction to client-get logic 4aa95ff In the case where the server is using a different dstore component, check that as well. 8a41b35 Remove the "<option> help" support 76850f6 Fix signed comparison warning 65df23e Ensure we check peer's gds for data b13e7d4 Silence Coverity warning 2a34472 build: Clean up delayed flags a1a5935 build: Use MCA env management for common/sse e15de4b build: Wrapper/pkg-config improvements 680326c build: check_package static improvements 330d2d4 Merge pull request open-mpi#2529 from bwbarrett/bugfix/summary_stream a819eeb build: Fix output stream bug in summary PRRTE Changes: c49eafc3ac Protect against proxy confusion 86bddb2abf Add some missing help verbiage 4e9029ccea slurm: fix breakage owing to rlm refactor 514553dedf Correctly determine when to daemonize backend prted 0db143da11 Some really minor cleanups c784c22947 build: check_package static improvements e0810859d7 Add missing CLI option and parsing a9e2303807 Merge pull request open-mpi#1292 from bwbarrett/bugfix/summary_stream 94b57788ca Merge pull request open-mpi#1291 from rhc54/topic/py fabb57117b build: Fix output stream bug in summary 17e6d86cbf Fix a problem with the "canonicalize_path" function Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
added a commit
to bwbarrett/ompi
that referenced
this pull request
Mar 30, 2022
PMIx Changes: fbc2513 build: Delay adding DELAYED_LIBS even more a83d564 Minor correction to client-get logic 4aa95ff In the case where the server is using a different dstore component, check that as well. 8a41b35 Remove the "<option> help" support 76850f6 Fix signed comparison warning 65df23e Ensure we check peer's gds for data b13e7d4 Silence Coverity warning 2a34472 build: Clean up delayed flags a1a5935 build: Use MCA env management for common/sse e15de4b build: Wrapper/pkg-config improvements 680326c build: check_package static improvements 330d2d4 Merge pull request open-mpi#2529 from bwbarrett/bugfix/summary_stream a819eeb build: Fix output stream bug in summary PRRTE Changes: c49eafc3ac Protect against proxy confusion 86bddb2abf Add some missing help verbiage 4e9029ccea slurm: fix breakage owing to rlm refactor 514553dedf Correctly determine when to daemonize backend prted 0db143da11 Some really minor cleanups c784c22947 build: check_package static improvements e0810859d7 Add missing CLI option and parsing a9e2303807 Merge pull request open-mpi#1292 from bwbarrett/bugfix/summary_stream 94b57788ca Merge pull request open-mpi#1291 from rhc54/topic/py fabb57117b build: Fix output stream bug in summary 17e6d86cbf Fix a problem with the "canonicalize_path" function Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
added a commit
to bwbarrett/ompi
that referenced
this pull request
Mar 31, 2022
PMIx Changes: fbc2513 build: Delay adding DELAYED_LIBS even more a83d564 Minor correction to client-get logic 4aa95ff In the case where the server is using a different dstore component, check that as well. 8a41b35 Remove the "<option> help" support 76850f6 Fix signed comparison warning 65df23e Ensure we check peer's gds for data b13e7d4 Silence Coverity warning 2a34472 build: Clean up delayed flags a1a5935 build: Use MCA env management for common/sse e15de4b build: Wrapper/pkg-config improvements 680326c build: check_package static improvements 330d2d4 Merge pull request open-mpi#2529 from bwbarrett/bugfix/summary_stream a819eeb build: Fix output stream bug in summary PRRTE Changes: c49eafc3ac Protect against proxy confusion 86bddb2abf Add some missing help verbiage 4e9029ccea slurm: fix breakage owing to rlm refactor 514553dedf Correctly determine when to daemonize backend prted 0db143da11 Some really minor cleanups c784c22947 build: check_package static improvements e0810859d7 Add missing CLI option and parsing a9e2303807 Merge pull request open-mpi#1292 from bwbarrett/bugfix/summary_stream 94b57788ca Merge pull request open-mpi#1291 from rhc54/topic/py fabb57117b build: Fix output stream bug in summary 17e6d86cbf Fix a problem with the "canonicalize_path" function Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Noel Rycroft for the report
Signed-off-by: Ralph Castain rhc@open-mpi.org