comm: add protection for NULL info #13109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to open-mpi#13108 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
| @@ -1451,7 +1451,7 @@ static int ompi_comm_idup_internal (ompi_communicator_t *comm, ompi_group_t *gro | |||
| } | |||
|
|
|||
| // Copy info if there is one. | |||
| { | |||
| if (info != NULL) { | |||
There was a problem hiding this comment.
I am not sure I understand why this check is required. ompi_info_memkind_copy_or_set already has check internally that recognizes if the info object is NULL, see https://github.com/open-mpi/ompi/blob/main/ompi/info/info_memkind.c#L560.
That being said, I see a potential issue a few lines further down in that the argument list of memkind_copy_or_set should take &comm->instance->super, instead of &comm->super. It looks like I overlooked this location when updating the behavior to retrieve the value from the instance (instead of the parent communicator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #13108