Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.x: configury: patch configure to support nvfortran #12876

Closed
wants to merge 1 commit into from

Conversation

bosilca
Copy link
Member

@bosilca bosilca commented Oct 23, 2024

nvfortran needs to be passed -fPIC when building shared libraries, so patch the generated configure script in order to properly handle nvfortran:

  • add nvfortran to the list of known fortran compilers
  • pass -fPIC to the compiler

Refs. #8919

Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp
Signed-off-by: George Bosilca gbosilca@nvidia.com
(cherry picked from commit ccd6415)

nvfortran needs to be passed -fPIC when building shared libraries,
so patch the generated configure script in order to properly
handle nvfortran:
- add nvfortran to the list of known fortran compilers
- pass -fPIC to the compiler

Refs. open-mpi#8919

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
Signed-off-by: George Bosilca <gbosilca@nvidia.com>
(cherry picked from commit ccd6415)
@bosilca bosilca added this to the v5.0.6 milestone Oct 23, 2024
@jsquyres jsquyres changed the title configury: patch configure to support nvfortran v5.0.x: configury: patch configure to support nvfortran Oct 23, 2024
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this in v4.1.x, too?

@bosilca bosilca closed this Oct 23, 2024
@bosilca
Copy link
Member Author

bosilca commented Oct 23, 2024

Messed-up my branch naming.

@bosilca
Copy link
Member Author

bosilca commented Oct 23, 2024

Backports: #12878 is for the 4.x and #12879 for the 5.x.

@bosilca bosilca deleted the topic/nvfortran branch October 23, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants