osc/sm: Fix detection of non-contig info #10195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the info subscribe for both the alloc_shared_noncontig and blocking_fence info keys. This change was inspired by issue open-mpi#10175, which highlighted that we were not properly following the non-contig info key (our behavior was standards compliant, but not particularly helpful), because the info subscription was overwriting the provided value. In the investigation, it became clear that there is really no advantage to subscribing to a key that can't be changed, so drop the subscription code for the two keys that can't be changed and fix a bug and remove code all at the same time. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
|
bot:aws:retest |
awlauria
approved these changes
Mar 31, 2022
awlauria
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the info subscribe for both the alloc_shared_noncontig and
blocking_fence info keys. This change was inspired by issue #10175,
which highlighted that we were not properly following the non-contig
info key (our behavior was standards compliant, but not particularly
helpful), because the info subscription was overwriting the provided
value. In the investigation, it became clear that there is really
no advantage to subscribing to a key that can't be changed, so
drop the subscription code for the two keys that can't be changed
and fix a bug and remove code all at the same time.
Signed-off-by: Brian Barrett bbarrett@amazon.com