Keep internal symbols from being visible in the GOT.

Signed-off-by: George Bosilca <gbosilca@nvidia.com>
open-mpi · Jun 3, 2024 · 17d3873 · 17d3873
1 parent bc03edf
commit 17d3873
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/opal/mca/accelerator/rocm/accelerator_rocm.h b/opal/mca/accelerator/rocm/accelerator_rocm.h
@@ -41,7 +41,7 @@ typedef struct {
 } opal_accelerator_rocm_component_t;
 
 OPAL_DECLSPEC extern opal_accelerator_rocm_component_t mca_accelerator_rocm_component;
-OPAL_DECLSPEC extern opal_accelerator_base_module_t opal_accelerator_rocm_module;
+extern opal_accelerator_base_module_t opal_accelerator_rocm_module;
 
 struct opal_accelerator_rocm_stream_t {
     opal_accelerator_stream_t base;
@@ -67,12 +67,12 @@ struct opal_accelerator_rocm_ipc_event_handle_t {
 typedef struct opal_accelerator_rocm_ipc_event_handle_t opal_accelerator_rocm_ipc_event_handle_t;
 OBJ_CLASS_DECLARATION(opal_accelerator_rocm_ipc_event_handle_t);
 
-OPAL_DECLSPEC extern hipStream_t opal_accelerator_rocm_MemcpyStream;
-OPAL_DECLSPEC extern int opal_accelerator_rocm_memcpy_async;
-OPAL_DECLSPEC extern int opal_accelerator_rocm_verbose;
-OPAL_DECLSPEC extern size_t opal_accelerator_rocm_memcpyH2D_limit;
-OPAL_DECLSPEC extern size_t opal_accelerator_rocm_memcpyD2H_limit;
+extern hipStream_t opal_accelerator_rocm_MemcpyStream;
+extern int opal_accelerator_rocm_memcpy_async;
+extern int opal_accelerator_rocm_verbose;
+extern size_t opal_accelerator_rocm_memcpyH2D_limit;
+extern size_t opal_accelerator_rocm_memcpyD2H_limit;
 
-OPAL_DECLSPEC extern int opal_accelerator_rocm_lazy_init(void);
+extern int opal_accelerator_rocm_lazy_init(void);
 
 #endif
diff --git a/opal/mca/accelerator/rocm/accelerator_rocm_component.c b/opal/mca/accelerator/rocm/accelerator_rocm_component.c
@@ -176,6 +176,7 @@ int opal_accelerator_rocm_lazy_init()
 
     err = hipStreamCreate(&opal_accelerator_rocm_MemcpyStream);
     if (hipSuccess != err) {
+	err = OPAL_ERROR;  // we got hipErrorInvalidValue, pretty bad
         opal_output(0, "Could not create hipStream, err=%d %s\n",
                 err, hipGetErrorString(err));
         goto out;