Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/jpgraph update #14

Merged
merged 2 commits into from
Aug 16, 2016
Merged

Topic/jpgraph update #14

merged 2 commits into from
Aug 16, 2016

Conversation

ggouaillardet
Copy link
Contributor

No description provided.

line attribute of the HorizontalGridLine class is now private, so define the
SetLineColor() method so ompi-www can sets its color.
@ggouaillardet
Copy link
Contributor Author

@rhc54 @jsquyres

i noticed https://www.open-mpi.org/software/ompi/v1.10/timeline-graph.php generates a bunch of errors, probably since php became pickier.

so i refresh jpgraph and wrote a simple patch to get it work.

since this issue is environment dependent, could you give this PR a try on hostgator servers ?

@jsquyres
Copy link
Member

With this additional patch, it works like a champ:

diff --git a/software/ompi/versions/timeline.php b/software/ompi/versions/timeli
index a4ac2a4..ddf54a6 100644
--- a/software/ompi/versions/timeline.php
+++ b/software/ompi/versions/timeline.php
@@ -5,7 +5,6 @@
   include_once("$topdir/includes/header.inc");

 function g($v) {
-    return;
     print("<p><div align=center><img src=\"../$v/timeline-graph.php\"></div></p
 }

@@ -21,5 +20,4 @@ g("v1.2");
 g("v1.1");
 g("v1.0");

-print("The Open MPI version timeline graphs are temporarily unavailable.\n");
   include_once("$topdir/includes/footer.inc");

I'll merge this and then commit the above patch. Thanks @ggouaillardet!

@jsquyres jsquyres merged commit b59639a into open-mpi:master Aug 16, 2016
bwbarrett pushed a commit that referenced this pull request Oct 7, 2018
bwbarrett pushed a commit that referenced this pull request Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants