Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Modify CI settings #44

Merged
merged 11 commits into from
Dec 24, 2021
Merged

[CI] Modify CI settings #44

merged 11 commits into from
Dec 24, 2021

Conversation

yl-1993
Copy link
Collaborator

@yl-1993 yl-1993 commented Dec 22, 2021 •
edited
Loading

@yl-1993 yl-1993 mentioned this pull request Dec 22, 2021
Closed
@codecov
Copy link

codecov bot commented Dec 22, 2021 •
edited
Loading

Codecov Report

Merging #44 (ca05f13) into main (d6a8f47) will increase coverage by 0.04%.
The diff coverage is 18.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   80.42%   80.46%   +0.04%     
==========================================
  Files         153      153              
  Lines       10995    11008      +13     
==========================================
+ Hits         8843     8858      +15     
+ Misses       2152     2150       -2
Flag Coverage Δ
unittests 80.46% <18.91%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmhuman3d/apis/train.py 20.31% <ø> (ø)
...re/visualization/renderer/matplotlib3d_renderer.py 100.00% <ø> (ø)
...zation/renderer/torch3d_renderer/depth_renderer.py 75.00% <0.00%> (ø)
...ation/renderer/torch3d_renderer/normal_renderer.py 69.76% <0.00%> (ø)
...ation/renderer/torch3d_renderer/render_datasets.py 100.00% <ø> (ø)
...n/renderer/torch3d_renderer/silhouette_renderer.py 73.33% <ø> (ø)
...uman3d/core/visualization/visualize_keypoints2d.py 81.89% <ø> (ø)
mmhuman3d/core/visualization/visualize_smpl.py 79.05% <ø> (ø)
mmhuman3d/data/data_structures/human_data.py 98.87% <ø> (ø)
mmhuman3d/data/datasets/human_image_dataset.py 82.68% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a8f47...ca05f13. Read the comment docs.

@LazyBusyYang
Copy link
Collaborator

We have not hooked markdownlint in pre-commit yet. See mmdet for official markdownlint:
https://github.com/open-mmlab/mmdetection/blob/master/.pre-commit-config.yaml#L31
Note: markdownlint in mmpose uses a non-official repo.

@yl-1993
Copy link
Collaborator Author

yl-1993 commented Dec 23, 2021 •
edited
Loading

Previously, we do not include markdownlint hook as it causes some trouble for developers, mainly due to the ruby and gem version on clusters.
This hook is added now and potential problem can be resolved by the following commands:

# install rvm
\curl -sSL https://get.rvm.io | bash
# install ruby >= 2.7
rvm install "ruby-2.7.1

@caizhongang
Copy link
Collaborator

caizhongang commented Dec 23, 2021 •
edited
Loading

Can you update the link to Wishlist in README.md and README_CN.md to this link please?

@yl-1993
Copy link
Collaborator Author

yl-1993 commented Dec 24, 2021

Can you update the link to Wishlist in README.md and README_CN.md to this link please?

Link of Wishlist has been updated.

@LazyBusyYang
Copy link
Collaborator

Seems good. Merging to main.

@LazyBusyYang LazyBusyYang merged commit eb9d735 into open-mmlab:main Dec 24, 2021
yl-1993 added a commit to yl-1993/mmhuman3d that referenced this pull request Dec 28, 2021
@yl-1993
[CI] Modify CI settings (open-mmlab#44)
40300c1 
* Revise badge url

* Skip CI when some specific files were changed

* Cancel previous runs that are not completed

* Revise paths-ignore

* Add markdownlint hook

* Add codespell hook

* Install ruby2.7

* Fix codespell

* Rename indexs to indexes

* Revise multiple person to multiple persons

* Change wishlist url
pangyyyyy added a commit that referenced this pull request Dec 28, 2021
@caizhongang @yl-1993
@LazyBusyYang @pangyyyyy
[Feature] Add GTA-Human data converter (#52)
f6d39e2 
* Add data converter for GTA-Human

* format

* bug fixes

* format

* Add unit test

* Remove __main__ in test_data_converters

* Add original GTA names

* [Feature] Upgrade SMPLify and body models (#31)

* Support joint mask in SMPLify and SMPL

* Allow body_model (not config) as the input

* Support on the flight batch_size adaptation

* Add match_init_batch_size to smplify-x

* Adapt to MMHuman3D camera module

* Fix dim bug

* Fix repeat bug

* Add unit tests: init param and adaptation to batch size

* Clean up

* Add perspective projection test

* Fix camera convention

* format

* Unit test bug fix

* bug fix: batch size check conditions

* bug fix: add camera in config

* Remove commented lines

* Modify structs to align with other data converters

* Use standard perspective projection

* anno -> ann

* format

* Add docs

* [CI] Modify CI settings (#44)

* Revise badge url

* Skip CI when some specific files were changed

* Cancel previous runs that are not completed

* Revise paths-ignore

* Add markdownlint hook

* Add codespell hook

* Install ruby2.7

* Fix codespell

* Rename indexs to indexes

* Revise multiple person to multiple persons

* Change wishlist url

* [Fix] update camera parameter (#46)

* add type check and update key check to avoid errors caused by json.dump

* fix comments

* fix type mis-align in h36m

* [Feature] Add Vibe converter (#39)

* add placeholders for vibe preprocessed data

* add vibe converter for mpi-inf-3dhp and pw3d

* add unittest for converter

* update folder structure

* add vibe converter to registry

* update hybrik config

* add documentation for contributing dataset and converter

* fix linting

* add check for device availability

* modify config to allow single device preprocessing

* improve clarity of documentation

* fix unit test

* format

* Add additional keys in unit test

Co-authored-by: caizhongang <caizhongang@sensetime.com>
Co-authored-by: Lei Yang <yangleidev@gmail.com>
Co-authored-by: LazyBusyYang <gaoyang_cn@outlook.com>
Co-authored-by: pangyyyyy <pangyyyyyy96@gmail.com>
ttxskk pushed a commit that referenced this pull request Jun 17, 2022
@yl-1993
[CI] Modify CI settings (#44)
466ec8f 
* Revise badge url

* Skip CI when some specific files were changed

* Cancel previous runs that are not completed

* Revise paths-ignore

* Add markdownlint hook

* Add codespell hook

* Install ruby2.7

* Fix codespell

* Rename indexs to indexes

* Revise multiple person to multiple persons

* Change wishlist url
ttxskk pushed a commit that referenced this pull request Jun 17, 2022
@caizhongang @yl-1993
@LazyBusyYang @pangyyyyy
[Feature] Add GTA-Human data converter (#52)
6e6276f 
* Add data converter for GTA-Human

* format

* bug fixes

* format

* Add unit test

* Remove __main__ in test_data_converters

* Add original GTA names

* [Feature] Upgrade SMPLify and body models (#31)

* Support joint mask in SMPLify and SMPL

* Allow body_model (not config) as the input

* Support on the flight batch_size adaptation

* Add match_init_batch_size to smplify-x

* Adapt to MMHuman3D camera module

* Fix dim bug

* Fix repeat bug

* Add unit tests: init param and adaptation to batch size

* Clean up

* Add perspective projection test

* Fix camera convention

* format

* Unit test bug fix

* bug fix: batch size check conditions

* bug fix: add camera in config

* Remove commented lines

* Modify structs to align with other data converters

* Use standard perspective projection

* anno -> ann

* format

* Add docs

* [CI] Modify CI settings (#44)

* Revise badge url

* Skip CI when some specific files were changed

* Cancel previous runs that are not completed

* Revise paths-ignore

* Add markdownlint hook

* Add codespell hook

* Install ruby2.7

* Fix codespell

* Rename indexs to indexes

* Revise multiple person to multiple persons

* Change wishlist url

* [Fix] update camera parameter (#46)

* add type check and update key check to avoid errors caused by json.dump

* fix comments

* fix type mis-align in h36m

* [Feature] Add Vibe converter (#39)

* add placeholders for vibe preprocessed data

* add vibe converter for mpi-inf-3dhp and pw3d

* add unittest for converter

* update folder structure

* add vibe converter to registry

* update hybrik config

* add documentation for contributing dataset and converter

* fix linting

* add check for device availability

* modify config to allow single device preprocessing

* improve clarity of documentation

* fix unit test

* format

* Add additional keys in unit test

Co-authored-by: caizhongang <caizhongang@sensetime.com>
Co-authored-by: Lei Yang <yangleidev@gmail.com>
Co-authored-by: LazyBusyYang <gaoyang_cn@outlook.com>
Co-authored-by: pangyyyyy <pangyyyyyy96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caizhongang caizhongang caizhongang left review comments

@LazyBusyYang LazyBusyYang LazyBusyYang approved these changes

Assignees

@LazyBusyYang LazyBusyYang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yl-1993 @LazyBusyYang @caizhongang