Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix meta information loading in runner.resume #1105

Closed
wants to merge 1 commit into from
Closed

[Fix] Fix meta information loading in runner.resume #1105

wants to merge 1 commit into from

Conversation

yeliudev
Copy link
Contributor

@yeliudev yeliudev commented Jun 17, 2021

The original runner.resume method loads all the meta information in the checkpoint, including epoch, iter, mmcv_version, mmdet_version (optional) into runner.meta. And these information will wrongly override the meta in subsequent checkpoints in runner.save_checkpoint. See here.

@yeliudev yeliudev changed the title Fix meta information loading in runner.resume [Fix] Fix meta information loading in runner.resume Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #1105 (d86525f) into master (004c006) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
- Coverage   67.62%   67.62%   -0.01%     
==========================================
  Files         159      159              
  Lines       10283    10282       -1     
  Branches     1857     1857              
==========================================
- Hits         6954     6953       -1     
  Misses       2964     2964              
  Partials      365      365              
Flag Coverage Δ
unittests 67.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/base_runner.py 77.38% <ø> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004c006...d86525f. Read the comment docs.

@yeliudev
Copy link
Contributor Author

Duplicate #1108.

@ZwwWayne ZwwWayne requested a review from ycxioooong June 25, 2021 07:31
@ZwwWayne ZwwWayne mentioned this pull request Jun 27, 2021
20 tasks
@ZwwWayne
Copy link
Collaborator

Directly remove that might be inappropriate. We plan to merge #1108 to fix this issue, so this PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants