Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1338 verifyVerticalHeights #1413

Draft
wants to merge 4 commits into
base: issue1338_verifyVerticalHeights
Choose a base branch
from

Conversation

kldjonge
Copy link
Contributor

This merge should be done AFTER #1411 (I branched out from this one) as it kind of goes togheter with the new assert there and a conflict would otherwise happen.

Two assert statements are added in the internal wall component that verify the consistency of hfloor and hzone at each internal wall when using stack-effect airflow (2-port). This is to avoid unphysical configurations when using the density driven airflow model.

closes #1338

@jelgerjansen jelgerjansen changed the base branch from master to issue1338_verifyVerticalHeights January 31, 2025 14:57
@kldjonge
Copy link
Contributor Author

kldjonge commented Feb 3, 2025

@jelgerjansen, to be clear on who does what. Do you want me to re-do the commits you reverted in the other pull request here? Or will you do it (and in the meantime review/check)?

@jelgerjansen
Copy link
Contributor

jelgerjansen commented Feb 4, 2025

@kldjonge you can keep these commits in this PR (to make sure they are finally merged in the master branch). However, there is a conflict between your branch and the remote branch I created.
You should merge the origin/issue1338_verifyVerticalHeights in your branch (kldjonge/hfloorcheck). This will throw a branch conflict error for the InternalWall model. This conflict should be solved by keeping your changes of InternalWall.

Once you are ready, we will do a final review, and I will consecutively merge this PR and merge origin/issue1338_verifyVerticalHeights in the master branch.

This is useful if an internal wall component is used but connected to the same zone at two sides.
@kldjonge kldjonge marked this pull request as draft February 5, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify whether hZone is filled in
2 participants