Project itz fixes v2 kdj #1388
Merged
Project itz fixes v2 kdj #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be consistent with airflowboxmodel
|
@kldjonge why did you use an initial equation to fix the temperature throughout the simulation? Does this still lead to the desired output? |
|
The commits here are just a (hopefully) Dymola 2022 friendly version of what the model allready was. Only the initial timestep will probably shift, but that is okay. The temperature is fixed to match the default CONTAM logic with fixed temperatures which I used to check implementation during development. The reason it stayed is because I want the indoor-outdoor temperature difference to be a driving force of airflow and just fixing the indoors seemed a clean way to achieve this. |
f708fe7
into
open-ideas:project_itz_fixes_v2
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial equation fixes for Dymola version used in CI