Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDJ fixes for Project itz fixes v2 #1345

Merged

Conversation

kldjonge
Copy link
Contributor

@kldjonge kldjonge commented Jan 12, 2024

This pull request contains fixes for the integrated airflow implementation. It contains debugging of various stack effect column heights as well as a proposal for fixing non-vertical large opening [d0b19d4]. This last mentioned commit might need a review as it required changes in the base classes that stem from the IBPSA library.

I am gradually adding features to the equivalent CONTAM model and new IDEAS\Buildings\Components\Validations\AirflowBoxModel.mo and IDEAS\Buildings\Components\Validations\TwoStoreyBoxes.mo models to verify the implementation and other differences. I implement fixes along the way to keep track of the validity.

Verification models (for these models I also have a CONTAM equivalent)

  • Update PPD12 structure
  • Create base airflow Box models
  • Create 2-storey model

Component/implementation

  • Outer Walls Check: crack/column heights implementation
  • Large opening in internal wall (stack heights check)
  • Window
  • Closed operable window
  • Open operable window
  • Trickle vent, stack-height check
  • Make nCom in large openings depend on actual height
  • Change default Cs for 2-port
  • FIX for trickle vent in the 1-port model which does not seem to have flow, [fixed in later commits]

Issues/nice to haves:

  • It would be good to be able to use the .PerfectAir medium as this is closer to how CONTAM functions.
  • Create vertical/horizontal door verification model and verify large opening model
  • add a building-level ACH output (can be calculated in the sim)
  • Clean up flow-output (now it can be very confusing which makes it hard to figure out which way the air is flowing)

@kldjonge
Copy link
Contributor Author

kldjonge commented Jan 16, 2024

Status: Flows are now correct but with a side-note. Large openings (opening in internal wall, open window) give larger flows in the CONTAM model but trends ect are plausible. (can be due to different factors: handling of low dp, deviations of rho, non-perfect air assumption in modelica vs ideal gas in contam..).

The large opening model uses an existing modelica model. According to me, this existing model is implemented in the correct way, so assuming the implementation of that model is correct we can conlude correct implementation of the 2-port implementation.

FYI @jelgerjansen

The default height is at the top of the window
Also moved around the models to fit in the new column resulting in annotation changes.
After long discussion among MZ airflow modellers it was proposed to use sim.Cs as default value for all surfaces also in the 2-port implementation.

I included an override in the siminfomanager  and outer surfaces to go back to the variable Cs implementation in combination with 2-port.
@kldjonge
Copy link
Contributor Author

Issue spotted: Trickle vent in the 1-port model does not seem to have flow

@flosfeld
Copy link

Concerning IDEAS.Buildings.Components.Window, I observed a high heat gain by ventilation for an open window with screen. This occurs when having 2 way flow, when the inflow is of the same magnitude as the outflow. The unexpected heat gain is caused by TShaScreen, which is to high. Reason for this is the variable m_flow, since this is the net value of flow received from outsideAir. In this case, the net flow value is close to 0, although it is both the inflow and outflow that should be taken into account.

@jelgerjansen jelgerjansen reopened this Feb 20, 2024
@jelgerjansen
Copy link
Contributor

I'll merge this PR together with PR #1351 in the open-ideas:project_itz_fixes_v2.
For further developments, please fork from the latest version of that branch.

@jelgerjansen jelgerjansen merged commit 82c6d3a into open-ideas:project_itz_fixes_v2 Feb 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants