Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation warning in building components #1402

Closed
kldjonge opened this issue Dec 20, 2024 · 9 comments · Fixed by #1411
Closed

Translation warning in building components #1402

kldjonge opened this issue Dec 20, 2024 · 9 comments · Fixed by #1411
Assignees
Milestone

Comments

@kldjonge
Copy link
Contributor

kldjonge commented Dec 20, 2024

Any suggestions on how to get rid of these warnings? They occur during checking/translation and only when an internal wall is used in the branches with the embedded interzonal airflow implementation. When a lot of internal walls are present, it clouds the translation log.

They happen always and I use IDEAS.Examples.Tutorial.Example1 to check. I tried some things but without succes and would like some input/ideas.

image

@jelgerjansen
Copy link
Contributor

jelgerjansen commented Jan 2, 2025

When I use the latest master branch, I also get a warning for the area

image

Thus I checked the difference in area definition between the master branch and airflow branch. I noticed that in the latter branch, the model PartialSurface has an additional real expression AExp whose value is equal to A. The output of that block is then connected to propsBusInt instead of layMul.A.

I copied this approach for the variables for which a warning appears (v50 and use_custom_q50):
image

If you correctly define their value and connect them to propsBusInt, the warnings disappear. I think the reason for this is some sort of "decoupling" between propsBusInt (connected to zone 1) and propsBus_b (connected to zone 2), as the latter still has the default connections.

However, since I didn't model this implementation myself, I have no clue whether or not this reasoning makes sense. @kldjonge I don't know if the solution above might give you some inspiration to find the "origin" of the problem (and a more elegant solution to get rid of the warnings)? If not, maybe @Mathadon can help us out here?

@kldjonge
Copy link
Contributor Author

kldjonge commented Jan 6, 2025

Thanks Jelger! This is what was needed. In fact, the q50_zone model should be writing that signal but for some reason it doesn't recognize is as output/input. A simple routing through a realpassthrough and booleanpasstrough respectively solves it, just like you suggest.

image

@kldjonge
Copy link
Contributor Author

kldjonge commented Jan 6, 2025

I made these changes here: https://github.com/kldjonge/IDEAS/tree/Development_master togheter with some changes nececarry to avoid warnings about units since Dymola 2025

@kldjonge
Copy link
Contributor Author

kldjonge commented Jan 6, 2025

Beware: it also holds commits to avoid unit conversion warnings but these have been fixed in IBPSA

@jelgerjansen
Copy link
Contributor

@kldjonge your fix is much more elegant, thanks! I'll merge this in the master branch once the interzonal airflow branch is merged.

Regarding the unit warnings: we merged the IBPSA library in the master branch at November 7 (commit 82957bb) thus this should be OK.

@jelgerjansen jelgerjansen self-assigned this Jan 7, 2025
@lucasverleyen lucasverleyen added this to the Release 3.x milestone Jan 10, 2025
@jelgerjansen jelgerjansen changed the title Translation warning in internal wall (airflow branch) Translation warning in building envelope components Jan 24, 2025
@jelgerjansen
Copy link
Contributor

@kldjonge I pushed these change to https://github.com/open-ideas/IDEAS/tree/issue1402_translationWarning and created a PR (for unit testing). I implemented all your commits except 23d49a4. Could you clarify when this results in a warning?

Let's use this issue and the corresponding pull request to solve some other warnings as well, among others:

  1. the one mentioned in Change default glazing type in RectangularZoneTemplate to avoid warnings obsolete type #1410 (you get a similar warning when running IDEAS.Buildings.Components.Examples.CavityWalls)

Image

  1. the ones below (you get those when running IDEAS.Buildings.Components.Examples.CavityInternalWall)

Image

@kldjonge
Copy link
Contributor Author

It's a minor one that last commit, the dymola 'check' can't properly run for de airmodel class as it assumes Vtot to be zero at that time and consequently a div0 error happens.

@jelgerjansen
Copy link
Contributor

@kldjonge could you help me out with the following warning?

Image

At line 153 of IDEAS.Airflow.Multizone.CrackOrOperableDoor, we find:

vZer=vZer*MFtrans*rho_default

This explains the conflict regarding units as depicted in the screenshot above (MFtrans is a mass flow rate and rho_default is a density). Is the equation incorrect? (MFtrans is defined as "Recommended mass flow rate used for reguralisation", so maybe we need to divide this somehow by another mass flow rate)

@jelgerjansen
Copy link
Contributor

@kldjonge I noticed you fixed this already via PR #1412, thanks!

jelgerjansen added a commit that referenced this issue Jan 31, 2025
@jelgerjansen jelgerjansen changed the title Translation warning in building envelope components Translation warning in building components Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants