Skip to content

Commit

Permalink
Fix problems with overriding final modifier of units
Browse files Browse the repository at this point in the history
  • Loading branch information
jelgerjansen committed Dec 9, 2024
1 parent 28ea57b commit 49f85f4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion IDEAS/Airflow/Multizone/CrackOrOperableDoor.mo
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ model CrackOrOperableDoor
parameter Modelica.Units.SI.MassFlowRate MFtrans=(hOpe*wOpe)*VItrans*REtrans/DOpe if useDoor and interZonalAirFlowType == IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts "Recommended massflowrate used for reguralisation";
parameter Modelica.Units.SI.Length DOpe=4*hOpe*wOpe/(2*hOpe+2*wOpe) if useDoor and interZonalAirFlowType == IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts "Estimated hydraulic diameter of the opening - 4*A/Perimeter";
constant Modelica.Units.SI.ReynoldsNumber REtrans=30 if useDoor and interZonalAirFlowType == IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts "Assumed Reynolds number at transition";
constant Modelica.Units.SI.DynamicViscosity VItrans(unit="kg/(m.s)")=0.0000181625 if useDoor and interZonalAirFlowType == IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts "Assumed dynamic viscosity of air at transition";
constant Modelica.Units.SI.DynamicViscosity VItrans=0.0000181625 if useDoor and interZonalAirFlowType == IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts "Assumed dynamic viscosity of air at transition";

final parameter Medium.ThermodynamicState state_default=Medium.setState_pTX(
T=Medium.T_default,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ model LargeHorizontalOpening
annotation (Placement(transformation(extent={{4,14},{-16,34}})));
Modelica.Blocks.Math.Sum MF_Orifice(nin=1, k={3600})
annotation (Placement(transformation(extent={{-180,28},{-200,48}})));
Modelica.Units.SI.MassFlowRate OpeningflowDiff(unit="kg/s")=abs(MF_Doormodel.y)-abs(MF_Orifice.y);
Modelica.Units.SI.MassFlowRate OpeningflowDiff=abs(MF_Doormodel.y)-abs(MF_Orifice.y);

protected
Fluid.Sensors.MassFlowRate MFsensor_Orifice(
Expand Down
2 changes: 1 addition & 1 deletion IDEAS/Airflow/Multizone/Validation/package.order
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
DoorOpenClosed
LargeHorizontalOpening
OneWayFlow
OpenDoorBuoyancyDynamic
OpenDoorBuoyancyPressureDynamic
OpenDoorPressure
OpenDoorTemperature
ThreeRoomsContam
ThreeRoomsContamDiscretizedDoor
LargeHorizontalOpening

0 comments on commit 49f85f4

Please sign in to comment.