Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] Drop allow_failures for nightly #55

Merged
merged 1 commit into from
Jul 26, 2017
Merged

[travis] Drop allow_failures for nightly #55

merged 1 commit into from
Jul 26, 2017

Conversation

behnam
Copy link
Member

@behnam behnam commented Jul 26, 2017

This will increase the time waiting for CI tests to pass, but we care
about the nightly test to pass and features depending on nightly to be
stable. So, better just drop allow_failures.

This will increase the time waiting for CI tests to pass, but we care
about the nightly test to pass and features depending on nightly to be
stable. So, better just drop `allow_failures`.
@behnam behnam merged commit ec8e9ab into master Jul 26, 2017
@behnam behnam deleted the travis branch July 26, 2017 20:07
@CAD97
Copy link
Collaborator

CAD97 commented Jul 26, 2017

Useful side effect: we can add a rustfmt and/or clippy check on the nightly CI which would fail on bad formatting or common code smells, respectively. (Note rust-lang/rust-clippy#1707 for clippy)

@behnam
Copy link
Member Author

behnam commented Jul 26, 2017

rustfmt sounds good. clippy still needs some work to get there.

I think we can do these under a separate matrix config from normal nightly build, so we can easily see which part (build/tests, vs formatting) is making a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants