-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For initial pre-release of GitOps Principles revised by the GitOps Working Group #4
Conversation
This commit proposes a succint definition of the GitOps principles with additional calrification. Co-authored-by: Scott Rigby <scott@r6by.com> Signed-off-by: Brice Fernandes <brice@weave.works>
509ebeb
to
df944e2
Compare
Thanks @tonit! Good catches all. Co-authored-by: Toni Menzel <toni.menzel@rebaze.com> Co-authored-by: Leonardo Murillo <leonardo@devops.cr> Signed-off-by: Scott Rigby <scott@r6by.com>
Thanks @murillodigital! Co-authored-by: Leonardo Murillo <leonardo@devops.cr> Signed-off-by: Scott Rigby <scott@r6by.com>
Thank you! Co-authored-by: Moshe Immerman <moshe@flanksource.com> Co-authored-by: Brian Fox <brianhfox@gmail.com> Co-authored-by: Leonardo Murillo <leonardo@devops.cr> Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: Moshe Immerman <moshe@flanksource.com> Signed-off-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Brice Fernandes <brice@weave.works>
Signed-off-by: Brice Fernandes <brice@weave.works>
Signed-off-by: Brice Fernandes <brice@weave.works>
Signed-off-by: Brice Fernandes <brice@weave.works>
Signed-off-by: Brice Fernandes <brice@weave.works>
Signed-off-by: Brice Fernandes <brice@weave.works>
Signed-off-by: Brice Fernandes <brice@weave.works>
Signed-off-by: Brice Fernandes <brice@weave.works>
Signed-off-by: Brice Fernandes <brice@weave.works>
28bda3a
to
180c424
Compare
@scottrigby wrote:
Hi, @scottrigby, When your time permits, I suggest that you skim For example, I noticed that @kmb385, @theWilliamChia and I commented in the above GitHub links, outside of live meetings. Perhaps others did too. My understanding of the GitHub links are intended to allow people who cannot attend live meetings to contribute asynchronously. In this PR, I just requested suggestions for docs: fix misspellings and grammar. If you include the suggestions, then please list me as a co-author accordingly.
Thank you @scottrigby 🙂 |
Thank you @lloydchang, merged suggestions. About users who reviewed the past PR, I wouldn't normally consider comments as part of git co-authorship – however in this case I think you are right. Async participants participated as much and in some cases more than live attendees of the Principles Committee meetings. Here are all the additional users who participated in in that PR and discussion:
* Note: I believe @ficcaglia who commented on gitops-working-group/gitops-working-group#48 is another account for @rficcaglia (example). I have reached out on Slack, but because I don't know their availability I do not want to hold up this PR merging if we can help it. Luckily because this account was created before 2017 we can use the GitHub no-reply email in the form of |
318a4cf
to
6f23d5c
Compare
Just a quick confirmation that this is the same Brian Fox as listed in the PR description. No need to duplicate. 😄 |
@scottrigby Any chance my email could be changed to |
…y 05, 2021 From https://hackmd.io/arwvV8NUQX683uBM3HzyNQ?both. Minus the notes that were not intended to be added to the PR. Signed-off-by: Scott Rigby <scott@r6by.com> Co-authored-by: Andrew Block <ablock@redhat.com> Co-authored-by: Shoubhik Bose <shbose@redhat.com> Co-authored-by: Kevin Bowersox <kmb385@gmail.com> Co-authored-by: Jesse Butler <butlerjl@amazon.com> Co-authored-by: Lloyd Chang <lloydchang@gmail.com> Co-authored-by: William Chia <thewilliamchia@gmail.com> Co-authored-by: Cornelia Davis <ornelia@corneliadavis.com> Co-authored-by: Brice Fernandes <brice@weave.works> Co-authored-by: Robert A Ficcaglia <rficcaglia@users.noreply.github.com> Co-authored-by: Brian Fox <brianhfox@gmail.com> Co-authored-by: Christian Hernandez <christian@redhat.com> Co-authored-by: Moshe Immerman <moshe@flanksource.com> Co-authored-by: Timothy Lin <timothylin@deloitte.com> Co-authored-by: Toni Menzel <toni.menzel@rebaze.com> Co-authored-by: Leonardo Murillo <leonardo@devops.cr> Co-authored-by: John Pitman <jpitman@redhat.com> Co-authored-by: Scott Rigby <scott@r6by.com> Co-authored-by: Chris Sanders <csand@microsoft.com> Co-authored-by: Carlos Santana <csantana@us.ibm.com> Co-authored-by: Schlomo Schapiro <schlomo@schapiro.org> Co-authored-by: Lothar Schulz <mail@lotharschulz.info> Co-authored-by: Regina Scott <rescott@redhat.com> Co-authored-by: Ishita Sequeira <isequeir@redhat.com> Co-authored-by: Roberth Strand <me@robstr.dev> Co-authored-by: Sean Sundberg <seansund@us.ibm.com>
Per last Principles Committee meeting. Also anchor glossary items Signed-off-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Scott Rigby <scott@r6by.com> Co-authored-by: lloydchang <lloydchang@gmail.com>
@sabre1041 absolutely, changed in description above and commit message ✅ |
Thanks @onematchfox 😸 |
@scottrigby sorry for the hassle! rficcaglia@gmail.com is fine or you can keep it as is - whichever is easier for you! |
|
||
### Principle 4 Notes | ||
|
||
- We talk here about "regular operations." In an emergency, other modes of operations, e.g. manual intervention, should be considered - followed by a reconciliation of the "tainted" system with the declared state. → resolve the conflict between "GitOps principle" and "I need to deal with problems that GitOps doesn't cover" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is considered "tainted"? The statement of "reconciliation of the 'tainted' system does not have a definition. Is 'tainted' a state that is defined by GitOps tool, the action of "manual intervention" or to the modification of the artifact outside the GitOps reconciliation cycle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this referring to an emergency temporary disconnection/pause of the GitOps reconciliation cycle to address the "emergency" and then, once the source of truth is updated, continue/reconnect/unpause the GitOps controller for resuming the reconciliations? If that is the case, would it be appropriate to state that a temporary pause of GitOps could happen, and resuming GitOps after that event should be treated like any initial reconciliation cycle where the cycle remediates towards Desired State?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@williamcaban Thanks for this question! This note a little rough. But yes, I think you have a good sense of the spirit it's intending to convey. This may feel repetitive, but here's a quick summary of the intentions for that principle and note:
- The intention of Principle 4 is to drive home the message that a system managed by GitOps should only be intentionally operated on through principles 1-3.
- The intention of this note on principle 4 is to acknowledge a caveat to that message: That individuals responsible for incident management may still need to temporarily bypass the normal GitOps process to handle an emergency.
So to answer your question, I think so yes. Typically this happens by:
- pausing GitOps reconciliation for a specific subsystem/component
- performing emergency actions directly on the system
- once addressed, in order to resume GitOps reconciliation, any directly applied "fixes" should be declared in the desired state, and reconciliation should be resumed.
Since these GitOps Principles are meant to be applied broadly – and specific use cases will build on them – we are being very careful not to assume anything about specific systems or tools within the principles or the notes.
If you have a specific proposal for updating the wording for this note to make it more clear, please feel free to propose it using GitHub suggestions directly on this PR. However, since we have already reached broad consensus on this for the initial pre-release, this PR is scheduled for merge very soon. If this PR merges before your suggestion is able to be properly reviewed/incorporated, you may open another PR against main after that point. Also, if you are able, please also join the weekly GitOps Principles Committee Meetings 😄 These are Wednesdays weekly at 19:00 GMT, unless otherwise specified.
The word 'tainted' could be removed. Use "...followed by a reconciliation of the system to the declared state. ...". |
This pull request is for an action item from the GitOps Working Group Principles Committee consensus to create the first pre-release of the revised GitOps Principles. The plan is to add this to a repo in the OpenGitOps project org.
Steps
GLOSSARY.md
,PRINCIPLES.md
,RATIONALE.md
main
of this repo, so that we can successfully create this public pull request (commits through 45cd99d)main
. This PR may be squash merged into main, as long as the co-authorship above is properly recordedv0.1.0
of the Principles - https://github.com/open-gitops/documents/releases/tag/v0.1.0Co-authors
Mar 29, 2021 attendees
April 05, 2021 attendees
April 14, 2021 attendees
April 28, 2021 attendees
May 05, 2021 attendees
Additional asynchronous participants on GitHub: #4 (comment)