-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address notes on the principles and remove the notes section #15
Conversation
Signed-off-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
…ent of that forthcoming recipe while not assuming Git Signed-off-by: Scott Rigby <scott@r6by.com>
I believe this is the gist of the note, including the to-do at the end Signed-off-by: Scott Rigby <scott@r6by.com>
The process of ensuring that the _Actual State_ of a sytem matches it's versioned _Desired State_ declarations. | ||
Contrary to CIops, any divergence between the two will trigger reconciliation, regardless of where changes occured. | ||
Divergence could be due to the actual state unintentionally _Drifting_ from the desired state declarations, or a new desired state declaration version having been changed intentionally. | ||
|
||
- ### Software System |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Software System glossary item needs work. I feel this is unclear: https://github.com/gitops-working-group/gitops-working-group/pull/48/files#diff-e76bd6f4d59f7e55fe3ce2f09d5e817bd9cc6991dbe62de27aadab5e68511043
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a revisited after RC 1 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @scottrigby, just a bunch of nits from me. Thank you! 🚀
- ### Reconciliation | ||
|
||
The process of ensuring that the _Actual State_ of a sytem matches it's versioned _Desired State_ declarations. | ||
Contrary to CIops, any divergence between the two will trigger reconciliation, regardless of where changes occured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be "where" or "how" changes occurred?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is meant to convey that unlike event driven CI, reconciliation doesn't only need to be triggered by an intentional change to the desired state stored in Git. Divergence could also happen in the runtime environment, accidentally (by a developer with permissions they shouldn't have), purposefully (by someone authorized to do incident management during an emergency or by a bad actor), or from some system failure, etc. Agents running inside the runtime who watch the desired state store allows divergence from whichever direction to trigger a reconciliation loop.
Maybe this could be worded differently, but this is what "where" was supposed to mean. Any suggestions on clarifying that in a simple way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually with that explanation, I see it clearly now. I was probably being pedantic, all good with it as is.
Co-authored-by: Jesse Butler <butlerjl@amazon.com> Signed-off-by: Scott Rigby <scott@r6by.com>
0368667
to
0443d12
Compare
Jesse commented above and noted on slack it's good to go
Note this is identified as a blocker for the
v1.0.0 milestonev1.0.0-rc.1 milestone.