Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address notes on the principles and remove the notes section #15

Merged
merged 5 commits into from
Sep 15, 2021

Conversation

scottrigby
Copy link
Member

@scottrigby scottrigby commented Jul 27, 2021

Signed-off-by: Scott Rigby <scott@r6by.com>
…ent of that forthcoming recipe while not assuming Git

Signed-off-by: Scott Rigby <scott@r6by.com>
I believe this is the gist of the note, including the to-do at the end

Signed-off-by: Scott Rigby <scott@r6by.com>
@scottrigby scottrigby added the enhancement New feature or request label Jul 27, 2021
@scottrigby scottrigby added this to the v1.0.0 milestone Jul 27, 2021
The process of ensuring that the _Actual State_ of a sytem matches it's versioned _Desired State_ declarations.
Contrary to CIops, any divergence between the two will trigger reconciliation, regardless of where changes occured.
Divergence could be due to the actual state unintentionally _Drifting_ from the desired state declarations, or a new desired state declaration version having been changed intentionally.

- ### Software System
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@scottrigby scottrigby Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a revisited after RC 1 👌

Copy link
Contributor

@jlbutler jlbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @scottrigby, just a bunch of nits from me. Thank you! 🚀

PRINCIPLES.md Outdated Show resolved Hide resolved
PRINCIPLES.md Outdated Show resolved Hide resolved
PRINCIPLES.md Outdated Show resolved Hide resolved
PRINCIPLES.md Outdated Show resolved Hide resolved
PRINCIPLES.md Outdated Show resolved Hide resolved
PRINCIPLES.md Outdated Show resolved Hide resolved
PRINCIPLES.md Outdated Show resolved Hide resolved
- ### Reconciliation

The process of ensuring that the _Actual State_ of a sytem matches it's versioned _Desired State_ declarations.
Contrary to CIops, any divergence between the two will trigger reconciliation, regardless of where changes occured.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "where" or "how" changes occurred?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to convey that unlike event driven CI, reconciliation doesn't only need to be triggered by an intentional change to the desired state stored in Git. Divergence could also happen in the runtime environment, accidentally (by a developer with permissions they shouldn't have), purposefully (by someone authorized to do incident management during an emergency or by a bad actor), or from some system failure, etc. Agents running inside the runtime who watch the desired state store allows divergence from whichever direction to trigger a reconciliation loop.

Maybe this could be worded differently, but this is what "where" was supposed to mean. Any suggestions on clarifying that in a simple way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually with that explanation, I see it clearly now. I was probably being pedantic, all good with it as is.

PRINCIPLES.md Outdated Show resolved Hide resolved
PRINCIPLES.md Outdated Show resolved Hide resolved
@scottrigby scottrigby modified the milestones: v1.0.0, v0.3.0 Jul 28, 2021
@scottrigby scottrigby modified the milestones: v0.3.0, v1.0.0-rc.1 Aug 11, 2021
Co-authored-by: Jesse Butler <butlerjl@amazon.com>

Signed-off-by: Scott Rigby <scott@r6by.com>
@scottrigby scottrigby requested a review from jlbutler September 15, 2021 19:18
@scottrigby scottrigby dismissed jlbutler’s stale review September 15, 2021 19:42

Jesse commented above and noted on slack it's good to go

@scottrigby scottrigby merged commit 631eb64 into main Sep 15, 2021
@scottrigby scottrigby deleted the move-notes branch September 15, 2021 19:43
@scottrigby scottrigby mentioned this pull request Sep 15, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure notes on the principles are all addressed so the section can be removed
2 participants