Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the current implementation of eHerkenning/eIDAS level selection per form #3969

Closed
joeribekker opened this issue Mar 4, 2024 · 6 comments · Fixed by maykinmedia/django-digid-eherkenning#65 or #4045
Assignees
Milestone

Comments

@joeribekker
Copy link
Contributor

Since this works completely different compared to DigiD. See ticket #3968 for adding it properly, but let's remove it for now since its not working at all.

@joeribekker
Copy link
Contributor Author

Refinement: We should check with Signicat how it should work: Multiple service IDs in the service catalog or can we specify a higher LoA in the request than that in the service catalog?

@SilviaAmAm
Copy link
Contributor

Question

In the service catalogue, inside the ServiceDefinition node, there is a AuthnContextClassRef node where the LoA is specified.
In the authentication request, there can be a RequestedAuthnContext node where also a AuthnContextClassRef with the LoA can be present.

From this documentation (https://afsprakenstelsel.etoegang.nl/display/as/Interface+specifications+HM-AD) I see:

When RequestedAuthnContext is included in the request, then it must contain a Level of assurance (AuthnContextClassRef) 
equal to or lower than the level of assurance included in the Service catalog for the requested service.

Is this functionality supported by Signicat?

Signicat answer
We support both [LoA in Service catalogue and AuthnRequest] place when a customer/implementationpartner sets this up.

However, we advise to let the ServiceCatalog to determine which LOA is going to be used, and not set it in the Authn request. This will prevent any confusion on which LOA should be mandatory.

i.e.: When the service has LOA 3 in the ServiceCatalog, it is not possible to set a lower LOA in the Authn.

Conclusion
I think then that we should remove this functionality? Since we supported setting a LoA higher than in the service catalogue (but this is not in agreement with the standard?) but Signicat does not support setting a lower LoA.

@SilviaAmAm SilviaAmAm moved this from Todo to In Progress in Development Mar 18, 2024
@joeribekker
Copy link
Contributor Author

Refinement: We checked and Signicat (preprod) allows us to login with a lower LoA than specificied in the service catalog (we logged in with LoA2 while the service catalog states LoA2+... and LoA2 is not even allowed anymore..)

@joeribekker
Copy link
Contributor Author

Refinement:
a) Ask with the standard whats the reasoning behind allowing a lower level to be sent than specified in the service catalog.
b) Who needs to validate the LoA that a user is logged in (see below)

ServiceCatalog: LoA2+
Form sents: LoA2+
User uses: LoA2

What happens? Will the broker stop the user or do we get the user with artificat LoA2 and stop the user ourselves?

@SilviaAmAm
Copy link
Contributor

SilviaAmAm commented Mar 18, 2024

@SilviaAmAm
Copy link
Contributor

Conclusion:
We can't set the LoA higher in the AuthnRequest because it is not conform to the standard.
We can't set the LoA lower, because it is discouraged by Signicat.
Therefore, we should remove this feature.

SilviaAmAm added a commit to maykinmedia/django-digid-eherkenning that referenced this issue Mar 21, 2024
…AuthnRequest

We can't set the LoA higher in the AuthnRequest because it is not conform to the standard.
We can't set the LoA lower, because it is discouraged by Signicat.
Therefore, we should remove this feature.
SilviaAmAm added a commit to maykinmedia/django-digid-eherkenning that referenced this issue Mar 21, 2024
SilviaAmAm added a commit to maykinmedia/django-digid-eherkenning that referenced this issue Mar 22, 2024
…AuthnRequest

We can't set the LoA higher in the AuthnRequest because it is not conform to the standard.
We can't set the LoA lower, because it is discouraged by Signicat.
Therefore, we should remove this feature.
SilviaAmAm added a commit to maykinmedia/django-digid-eherkenning that referenced this issue Mar 22, 2024
SilviaAmAm added a commit that referenced this issue Mar 22, 2024
To specify if that auth plugin supports overriding the LoA in the authentication request
SilviaAmAm added a commit that referenced this issue Mar 22, 2024
SilviaAmAm added a commit that referenced this issue Mar 22, 2024
SilviaAmAm added a commit that referenced this issue Mar 22, 2024
To specify if that auth plugin supports overriding the LoA in the authentication request
SilviaAmAm added a commit that referenced this issue Mar 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Mar 29, 2024
@SilviaAmAm SilviaAmAm reopened this Mar 29, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Development Mar 29, 2024
SilviaAmAm added a commit that referenced this issue Mar 29, 2024
To specify if that auth plugin supports overriding the LoA in the authentication request
SilviaAmAm added a commit that referenced this issue Mar 29, 2024
SilviaAmAm added a commit that referenced this issue Apr 2, 2024
To specify if that auth plugin supports overriding the LoA in the authentication request
SilviaAmAm added a commit that referenced this issue Apr 2, 2024
SilviaAmAm added a commit that referenced this issue Apr 2, 2024
sergei-maertens added a commit that referenced this issue Apr 2, 2024
…nning-loa-overwrite

[#3969] Remove ability to override LoA for eHekrenning/eIDAS
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Apr 2, 2024
Viicos pushed a commit that referenced this issue Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment