Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new --sources arg in flagd startup in pod webook #389

Closed
toddbaert opened this issue Mar 14, 2023 · 0 comments · Fixed by #427
Closed

Use new --sources arg in flagd startup in pod webook #389

toddbaert opened this issue Mar 14, 2023 · 0 comments · Fixed by #427
Assignees
@Kavindu-Dodan

Comments

@toddbaert
Copy link
Member

toddbaert commented Mar 14, 2023 •
edited
Loading

Now that we can configure all sources with a single command line arg, we should use this to configure flagd in OFO.

*NOTE: this will require a minimum flagd version in OFO. We might not want to maintain backward compatibility here, so perhaps OFO should error if you attempt to deploy flagd's not supporting this config, going forward.
@toddbaert toddbaert converted this from a draft issue Mar 14, 2023
@toddbaert toddbaert mentioned this issue Mar 14, 2023
Closed
@Kavindu-Dodan Kavindu-Dodan self-assigned this Mar 17, 2023
@Kavindu-Dodan Kavindu-Dodan mentioned this issue Mar 20, 2023
Closed
@Kavindu-Dodan Kavindu-Dodan moved this from In Progress to In Review in ⚡ Realtime flag updates via gRPC in K8s Mar 20, 2023
@Kavindu-Dodan Kavindu-Dodan moved this from In Review to In Progress in ⚡ Realtime flag updates via gRPC in K8s Mar 22, 2023
@Kavindu-Dodan Kavindu-Dodan mentioned this issue Mar 24, 2023
Merged
Kavindu-Dodan added a commit to open-feature/flagd that referenced this issue Mar 28, 2023
@Kavindu-Dodan @toddbaert
chore!: unify sources configuration handling (#560)
7f4888a 
## This PR

This PR is best reviewed by going through the new documentation [1]

Restructured flagd startup configuration handling with respect to sync
providers. Documentation is updated [1] & handling of prefixes is
cleared (ex:- removal of grpc(s):// prefix for `--source` based sync
provider startup argument)

## Breaking change

Contains a breaking change with respect to how sync provider URIs are
handled

- **what** -source configuration URI parsing
- **why** - align source configuration handling among different sources
& avoid mix uage of prefixes to aling with documented behavior
- **how** - source configuration no longer validate or parse URI
prefixes. This means, existing source configuration strings/files may
need an upgrade if they used prefixes in URIs. The upgrade is to simply
remove any prefixes from source configuration URIs

For example, 

**old**

``` yaml
sources:
- uri: grpcs://my-flag-source:8080 # mixed usage of schema shared with URI prefixes ❌ 
  provider: grpc
  certPath: /certs/ca.cert
```

**new**

``` yaml
sources:
- uri: my-flag-source:8080
  provider: grpc
  tls: true. # new way to convey secure connection requirement ✅ 
  certPath: /certs/ca.cert
```
____

Is a pre-requisite of
open-feature/open-feature-operator#389


[1] -
https://github.com/open-feature/flagd/blob/2a4783ef61eb3756e7a3f99aae596392906cd765/docs/configuration/configuration.md

---------

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com>
@Kavindu-Dodan Kavindu-Dodan mentioned this issue Mar 29, 2023
Merged
@Kavindu-Dodan Kavindu-Dodan moved this from In Progress to In Review in ⚡ Realtime flag updates via gRPC in K8s Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kavindu-Dodan Kavindu-Dodan

Labels
None yet
Projects
⚡ Realtime flag updates via gRPC in K8s
Status: Done
Milestone
No milestone
2 participants
@Kavindu-Dodan @toddbaert