Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Statsig provider #445

Merged
merged 11 commits into from
Mar 15, 2024
Merged

Conversation

liran2000
Copy link
Member

Add Statsig GO Provider.

@MovieStoreGuy, @jasonwzm, @xinlili-statsig, @kenny-statsig, @Kavindu-Dodan, @toddbaert you are welcome to review.

@liran2000 liran2000 requested a review from a team as a code owner February 3, 2024 16:03
@github-actions github-actions bot requested a review from sighphyre February 3, 2024 16:03
@liran2000 liran2000 changed the title Feature/statsig feat: Add Statsig provider Feb 3, 2024
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for minor remarks, this looks good from OF poitn of view

Copy link

@kenny-statsig kenny-statsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you

providers/statsig/pkg/provider.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any blockers other than for the comments I left

@liran2000
Copy link
Member Author

@Kavindu-Dodan, @toddbaert this is ready for merge

@Kavindu-Dodan Kavindu-Dodan requested a review from toddbaert March 5, 2024 19:06
liran2000 and others added 10 commits March 11, 2024 11:58
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Signed-off-by: Liran M <77168114+liran2000@users.noreply.github.com>
@toddbaert toddbaert merged commit 409a06f into open-feature:main Mar 15, 2024
5 checks passed
@toddbaert
Copy link
Member

Merging! Thanks as always @liran2000 and @kenny-statsig , @Kavindu-Dodan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants