Skip to content

Commit

Permalink
chore: remove verbose flag from e2e tests (#617)
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
  • Loading branch information
beeme1mr authored Jan 30, 2025
1 parent 6da46d9 commit 54f811b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
9 changes: 4 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
go 1.19+ is recommended.

## Setup workspace

Run the following command to set up the go workspace:

```shell
Expand All @@ -31,7 +31,7 @@ make MODULE_NAME=NAME new-provider

To automatically create and set up a new hook directory, use the following command (requires [jq](https://jqlang.github.io/jq/)):

```
```shell
make MODULE_NAME=NAME new-hook
```

Expand All @@ -40,7 +40,7 @@ Note - [jq documentation](https://stedolan.github.io/jq/download/)
### Versioning

The release version of the newly added module(hook/provider) is controlled by `.release-please-manifest.json`.
You can control the versioning of your module by adding an entry with desired initial version(ex:`"provider/acme":"0.0.1"`).
You can control the versioning of your module by adding an entry with desired initial version(ex:`"provider/acme":"0.0.1"`).
Otherwise, default versioning will start from `1.0.0`.

## Documentation
Expand All @@ -58,7 +58,7 @@ To run tests in all existing go modules, use the command:
make test
```

It is recommended to include end-to-end (e2e) tests in your provider when possible.
It is recommended to include end-to-end (e2e) tests in your provider when possible.
If you have dependency services for your e2e tests, make sure to add them as service in the build pipeline.
Also, make sure to include them in the makefile for easy use by contributors.

Expand Down Expand Up @@ -88,4 +88,3 @@ Merging the Release Please PR will create a GitHub release with updated library
## Dependencies

The [GO-SDK](https://github.com/open-feature/go-sdk) should be a _peer dependency_ of your module.

2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ e2e-remove-helpers:
docker rm $(FLAGD_SYNC)

e2e:
go clean -testcache && go list -f '{{.Dir}}/...' -m | xargs -I{} go test -tags=e2e -v {}
go clean -testcache && go list -f '{{.Dir}}/...' -m | xargs -I{} go test -tags=e2e {}

lint:
go install -v github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.1
Expand Down

0 comments on commit 54f811b

Please sign in to comment.