Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] FlagD returns exit code zero on error #169

Closed
beeme1mr opened this issue Sep 21, 2022 · 2 comments
Closed

[BUG] FlagD returns exit code zero on error #169

beeme1mr opened this issue Sep 21, 2022 · 2 comments
Assignees
@AlexsJones
Labels
bug Something isn't working Needs Triage This issue needs to be investigated by a maintainer

Comments

@beeme1mr
Copy link
Member

Observed behavior

FlagD returns exit code zero on error

Expected Behavior

FlagD should return a non-zero exit code when an error occurs.

Steps to reproduce

  1. Run docker run -p 8013:8013 -it ghcr.io/open-feature/flagd:v0.1.0 start --uri /invalid/path.json
  2. Run echo $?
@beeme1mr beeme1mr added bug Something isn't working Needs Triage This issue needs to be investigated by a maintainer labels Sep 21, 2022
@AlexsJones AlexsJones self-assigned this Sep 22, 2022
@AlexsJones
Copy link
Member

#170

@AlexsJones AlexsJones mentioned this issue Sep 22, 2022
Merged
AlexsJones added a commit that referenced this issue Sep 23, 2022
@AlexsJones
fix: bubbles up unclean error exits (#170)
9f7db02 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>

#169

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@toddbaert
Copy link
Member

Closed with #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexsJones AlexsJones

Labels
bug Something isn't working Needs Triage This issue needs to be investigated by a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@beeme1mr @AlexsJones @toddbaert