Skip to content

Commit

Permalink
ci: remove release please config for flagd versions (#542)
Browse files Browse the repository at this point in the history
Signed-off-by: James Milligan <james@omnant.co.uk>
  • Loading branch information
james-milligan authored Mar 20, 2023
1 parent 4e57f93 commit a3f83ea
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
2 changes: 1 addition & 1 deletion config/deployments/kube-flagd-proxy/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
openfeature.dev/allowkubernetessync: "true"
spec:
containers:
- image: ghcr.io/open-feature/kube-flagd-proxy:v0.1.1 # x-release-please-version
- image: ghcr.io/open-feature/kube-flagd-proxy:latest
name: kube-flagd-proxy
ports:
- containerPort: 8015
Expand Down
6 changes: 3 additions & 3 deletions kube-flagd-proxy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ kubectl apply -f ./config/deployments/kube-flagd-proxy
```

Once the kube-proxy has been deployed any flagd instance subscribe to flag changes using the grpc sync, providing the target resource uri using the `selector` configuration field.
<!-- x-release-please-start-version -->

```yaml
apiVersion: v1
kind: Pod
Expand All @@ -31,7 +31,7 @@ metadata:
spec:
containers:
- name: flagd
image: ghcr.io/open-feature/flagd:v0.4.4
image: ghcr.io/open-feature/flagd:latest
ports:
- containerPort: 8013
args:
Expand All @@ -56,5 +56,5 @@ spec:
yellow: yellow
defaultVariant: yellow
```
<!-- x-release-please-end -->
Once deployed, the client flagd instance will be receiving almost instant flag configuration change events.
8 changes: 2 additions & 6 deletions release-please-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,15 @@
"bump-patch-for-minor-pre-major": true,
"versioning": "default",
"extra-files": [
"snap/snapcraft.yaml",
"../kube-flagd-proxy/README.md"
"snap/snapcraft.yaml"
]
},
"kube-flagd-proxy": {
"release-type": "go",
"package-name": "kube-flagd-proxy",
"versioning": "default",
"bump-minor-pre-major": true,
"bump-patch-for-minor-pre-major": true,
"extra-files": [
"../config/deployments/kube-flagd-proxy/deployment.yaml"
]
"bump-patch-for-minor-pre-major": true
},
"core": {
"release-type": "go",
Expand Down

1 comment on commit a3f83ea

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: a3f83ea Previous: 4f7b3cf Ratio
BenchmarkResolveBooleanValue/test_staticBoolFlag 1667 ns/op 96 B/op 4 allocs/op 1270 ns/op 96 B/op 4 allocs/op 1.31

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.