ci: expanded benchmark coverage (#213)

open-feature · Dec 13, 2022 · 8108d7d · 8108d7d
1 parent c2a9ac9
commit 8108d7d
Show file tree

Hide file tree

Showing 2 changed files with 393 additions and 41 deletions.
diff --git a/pkg/eval/fractional_evaluation_test.go b/pkg/eval/fractional_evaluation_test.go
@@ -5,7 +5,6 @@ import (
 
 	"github.com/open-feature/flagd/pkg/logger"
 	"github.com/open-feature/flagd/pkg/model"
-
 	"google.golang.org/protobuf/types/known/structpb"
 )
 
@@ -176,26 +175,26 @@ func TestFractionalEvaluation(t *testing.T) {
 							"yellow": "#FFFF00",
 						},
 						Targeting: []byte(`{
-												"fractionalEvaluation": [
-												  "email",
-												  [
-													"red",
-													25
-												  ],
-												  [
-													"blue",
-													25
-												  ],
-												  [
-													"green",
-													25
-												  ],
-												  [
-													"yellow",
-													25
-												  ]
-												]
-											  }`),
+							"fractionalEvaluation": [
+								"email",
+								[
+								"red",
+								25
+								],
+								[
+								"blue",
+								25
+								],
+								[
+								"green",
+								25
+								],
+								[
+								"yellow",
+								25
+								]
+							]
+							}`),
 					},
 				},
 			},
@@ -218,14 +217,14 @@ func TestFractionalEvaluation(t *testing.T) {
 							"yellow": "#FFFF00",
 						},
 						Targeting: []byte(`{
-												"fractionalEvaluation": [
-												  "email",
-												  [
-													"black",
-													100
-												  ]
-												]
-											  }`),
+							"fractionalEvaluation": [
+								"email",
+								[
+								"black",
+								100
+								]
+							]
+							}`),
 					},
 				},
 			},
@@ -252,18 +251,18 @@ func TestFractionalEvaluation(t *testing.T) {
 							"yellow": "#FFFF00",
 						},
 						Targeting: []byte(`{
-												"fractionalEvaluation": [
-												  "email",
-												  [
-													"red",
-													25
-												  ],
-												  [
-													"blue",
-													25
-												  ]
-												]
-											  }`),
+							"fractionalEvaluation": [
+								"email",
+								[
+								"red",
+								25
+								],
+								[
+								"blue",
+								25
+								]
+							]
+							}`),
 					},
 				},
 			},
@@ -306,3 +305,136 @@ func TestFractionalEvaluation(t *testing.T) {
 		})
 	}
 }
+
+func BenchmarkFractionalEvaluation(b *testing.B) {
+	flags := Flags{
+		Flags: map[string]Flag{
+			"headerColor": {
+				State:          "ENABLED",
+				DefaultVariant: "red",
+				Variants: map[string]any{
+					"red":    "#FF0000",
+					"blue":   "#0000FF",
+					"green":  "#00FF00",
+					"yellow": "#FFFF00",
+				},
+				Targeting: []byte(`{
+					"if": [
+						{
+						"in": ["@faas.com", {
+								"var": ["email"]
+								}]
+						},
+						{
+						"fractionalEvaluation": [
+							"email",
+							[
+							"red",
+							25
+							],
+							[
+							"blue",
+							25
+							],
+							[
+							"green",
+							25
+							],
+							[
+							"yellow",
+							25
+							]
+						]
+						}, null
+					]
+					}`),
+			},
+		},
+	}
+
+	tests := map[string]struct {
+		flags           Flags
+		flagKey         string
+		context         *structpb.Struct
+		expectedValue   string
+		expectedVariant string
+		expectedReason  string
+		expectedError   error
+	}{
+		"test@faas.com": {
+			flags:   flags,
+			flagKey: "headerColor",
+			context: &structpb.Struct{Fields: map[string]*structpb.Value{
+				"email": {Kind: &structpb.Value_StringValue{
+					StringValue: "test@faas.com",
+				}},
+			}},
+			expectedVariant: "red",
+			expectedValue:   "#FF0000",
+			expectedReason:  model.TargetingMatchReason,
+		},
+		"test2@faas.com": {
+			flags:   flags,
+			flagKey: "headerColor",
+			context: &structpb.Struct{Fields: map[string]*structpb.Value{
+				"email": {Kind: &structpb.Value_StringValue{
+					StringValue: "test2@faas.com",
+				}},
+			}},
+			expectedVariant: "yellow",
+			expectedValue:   "#FFFF00",
+			expectedReason:  model.TargetingMatchReason,
+		},
+		"test3@faas.com": {
+			flags:   flags,
+			flagKey: "headerColor",
+			context: &structpb.Struct{Fields: map[string]*structpb.Value{
+				"email": {Kind: &structpb.Value_StringValue{
+					StringValue: "test3@faas.com",
+				}},
+			}},
+			expectedVariant: "red",
+			expectedValue:   "#FF0000",
+			expectedReason:  model.TargetingMatchReason,
+		},
+		"test4@faas.com": {
+			flags:   flags,
+			flagKey: "headerColor",
+			context: &structpb.Struct{Fields: map[string]*structpb.Value{
+				"email": {Kind: &structpb.Value_StringValue{
+					StringValue: "test4@faas.com",
+				}},
+			}},
+			expectedVariant: "blue",
+			expectedValue:   "#0000FF",
+			expectedReason:  model.TargetingMatchReason,
+		},
+	}
+	reqID := "test"
+	for name, tt := range tests {
+		b.Run(name, func(b *testing.B) {
+			je := JSONEvaluator{state: tt.flags}
+			for i := 0; i < b.N; i++ {
+				value, variant, reason, err := resolve[string](
+					reqID, tt.flagKey, tt.context, je.evaluateVariant, je.state.Flags[tt.flagKey].Variants,
+				)
+
+				if value != tt.expectedValue {
+					b.Errorf("expected value '%s', got '%s'", tt.expectedValue, value)
+				}
+
+				if variant != tt.expectedVariant {
+					b.Errorf("expected variant '%s', got '%s'", tt.expectedVariant, variant)
+				}
+
+				if reason != tt.expectedReason {
+					b.Errorf("expected reason '%s', got '%s'", tt.expectedReason, reason)
+				}
+
+				if err != tt.expectedError {
+					b.Errorf("expected err '%v', got '%v'", tt.expectedError, err)
+				}
+			}
+		})
+	}
+}