Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LTO linking #1110

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Fix LTO linking #1110

merged 1 commit into from
Aug 25, 2022

Conversation

metsma
Copy link
Contributor

@metsma metsma commented Aug 12, 2022

Signed-off-by: Raul Metsma raul@metsma.ee

Signed-off-by: Raul Metsma <raul@metsma.ee>
@kristelmerilain kristelmerilain merged commit abc26aa into open-eid:master Aug 25, 2022
@metsma metsma deleted the lto branch August 25, 2022 15:43
@klemensn
Copy link
Contributor

klemensn commented Dec 22, 2022

This breaks the build on OpenBSD:

$ c++ --version
OpenBSD clang version 13.0.0
Target: amd64-unknown-openbsd7.2
Thread model: posix
InstalledDir: /usr/bin
: && /usr/ports/pobj/qdigidoc4-4.2.14/bin/c++ -O2 -pipe -DNDEBUG -flto=thin -Wl,-rpath,/usr/local/lib/pkcs11 -Wl,-object_path_lto,lto.o client/CMakeFiles/TSLDownload.dir/TSLDownload_autogen/mocs_compilation.cpp.o client/CMakeFiles/TSLDownload.dir/TSLDownload.cpp.o -o client/TSLDownload  -Wl,-z,origin,-rpath,/usr/local/lib  /usr/local/lib/libQt6Network.so.0.3  /usr/local/lib/libQt6Core.so.1.0  -pthread  -Wl,-rpath-link,/usr/X11R6/lib:/usr/local/lib && :
ld: error: cannot open lto.o: No such file or directory
c++: error: linker command failed with exit code 1 (use -v to see invocation)

As a temporary workaround, I've simply removed the added hunk and everything builds and links fine.

@evaikene
Copy link

Also breaks build on Linux with the same linker error, if CXX is set clang++.

metsma added a commit to metsma/DigiDoc4-Client that referenced this pull request Dec 28, 2022
IB-7539, open-eid#1110

Signed-off-by: Raul Metsma <raul@metsma.ee>
metsma added a commit to metsma/DigiDoc4-Client that referenced this pull request Dec 28, 2022
IB-7539, open-eid#1110

Signed-off-by: Raul Metsma <raul@metsma.ee>
@metsma
Copy link
Contributor Author

metsma commented Dec 28, 2022

Can you test #1146 pull request

metsma added a commit to metsma/DigiDoc4-Client that referenced this pull request Dec 28, 2022
IB-7539, open-eid#1110

Signed-off-by: Raul Metsma <raul@metsma.ee>
metsma added a commit to metsma/DigiDoc4-Client that referenced this pull request Dec 28, 2022
IB-7539, open-eid#1110

Signed-off-by: Raul Metsma <raul@metsma.ee>
metsma added a commit to metsma/DigiDoc4-Client that referenced this pull request Dec 28, 2022
IB-7539, open-eid#1110

Signed-off-by: Raul Metsma <raul@metsma.ee>
@evaikene
Copy link

Can you test #1146 pull request

Yes that works on Arch Linux with CXX set to clang++

metsma added a commit to metsma/DigiDoc4-Client that referenced this pull request Dec 28, 2022
IB-7539, open-eid#1110

Signed-off-by: Raul Metsma <raul@metsma.ee>
metsma added a commit to metsma/DigiDoc4-Client that referenced this pull request Dec 28, 2022
IB-7539, open-eid#1110

Signed-off-by: Raul Metsma <raul@metsma.ee>
@klemensn
Copy link
Contributor

Can you test #1146 pull request

Cherry-picking the following fixes the OpenBSD clang build, thanks:
https://github.com/open-eid/DigiDoc4-Client/pull/1146/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL24-L28

The rest of this PR (qt{5 -> 6}-* package changes, internal version bump and changelog) seems entirely unrelated.

kristelmerilain pushed a commit that referenced this pull request Jan 10, 2023
IB-7539, #1110

Signed-off-by: Raul Metsma <raul@metsma.ee>

Signed-off-by: Raul Metsma <raul@metsma.ee>
karl80038 pushed a commit to karl80038/DigiDoc4-Client that referenced this pull request May 24, 2023
IB-7539, open-eid#1110

Signed-off-by: Raul Metsma <raul@metsma.ee>

Signed-off-by: Raul Metsma <raul@metsma.ee>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants